New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806328 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR

Blocking:
issue 715118



Sign in to add a comment

VR: Disable assets ready snackbar

Project Member Reported by tiborg@chromium.org, Jan 26 2018

Issue description

Per UX feedback, we don't want to show the snackbar anymore when a new component version becomes ready while in VR.
 

Comment 1 by tiborg@chromium.org, Jan 26 2018

Cc: vollick@chromium.org

Comment 2 by tiborg@chromium.org, Jan 26 2018

Blocking: 715118

Comment 3 by tiborg@chromium.org, Jan 26 2018

Summary: VR: Disable assets ready snackbar (was: VR: Remove assets ready snackbar)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/086bb77ef26bd5c11ec3078ab4302fc09e0ec220

commit 086bb77ef26bd5c11ec3078ab4302fc09e0ec220
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Sat Jan 27 04:33:14 2018

[vr] Disable update ready snackbar

Bug:  806328 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic11d57e15fdd3645365c07d80addd672b838ac3e
Reviewed-on: https://chromium-review.googlesource.com/889680
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532154}
[modify] https://crrev.com/086bb77ef26bd5c11ec3078ab4302fc09e0ec220/chrome/browser/vr/model/model.h
[modify] https://crrev.com/086bb77ef26bd5c11ec3078ab4302fc09e0ec220/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/086bb77ef26bd5c11ec3078ab4302fc09e0ec220/chrome/browser/vr/ui_scene_creator.cc

Comment 5 by tiborg@chromium.org, Jan 29 2018

Labels: Merge-Request-65
Please add affected OSs.

Comment 7 by tiborg@chromium.org, Jan 29 2018

Labels: OS-Android
Added OS.
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 30 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 30 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf7d2a9f742d515b15bbc19f9d58f52219eec3fd

commit bf7d2a9f742d515b15bbc19f9d58f52219eec3fd
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Jan 30 22:38:57 2018

[vr] Disable update ready snackbar

TBR=tiborg@chromium.org

(cherry picked from commit 086bb77ef26bd5c11ec3078ab4302fc09e0ec220)

Bug:  806328 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic11d57e15fdd3645365c07d80addd672b838ac3e
Reviewed-on: https://chromium-review.googlesource.com/889680
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532154}
Reviewed-on: https://chromium-review.googlesource.com/894493
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#186}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/bf7d2a9f742d515b15bbc19f9d58f52219eec3fd/chrome/browser/vr/model/model.h
[modify] https://crrev.com/bf7d2a9f742d515b15bbc19f9d58f52219eec3fd/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/bf7d2a9f742d515b15bbc19f9d58f52219eec3fd/chrome/browser/vr/ui_scene_creator.cc

Status: Fixed (was: Started)
Labels: Test-Complete

Sign in to add a comment