New issue
Advanced search Search tips

Issue 806318 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 682402


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Get Ash display mirroring and unified desktop working for mus+viz/mustash.

Project Member Reported by msw@chromium.org, Jan 26 2018

Issue description

Get Ash display mirroring and unified desktop working for mus+viz/mustash.

 Issue 764472  and  Issue 770243  were morphed into targeting mus without viz.
The next step is to support the same display management features in mus with viz.
I have an old WIP CL that may contain some useful work: http://crrev.com/c/775653

chrome --ash-enable-unified-desktop --ash-host-window-bounds=400x400,450+0-400x400 --mus --mus-hosting-viz

 
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51935a939ac01a2b974b13836bc9d4061ab33e42

commit 51935a939ac01a2b974b13836bc9d4061ab33e42
Author: Mike Wasserman <msw@chromium.org>
Date: Wed Feb 28 05:10:05 2018

mus+viz: Update mirroring and unified mode todos

TBR=sky@chromium.org

Bug:  764472 ,  806318 
Change-Id: Ife275bdd5eb1aed5f0a8d2117d7796e1a3e1e4cd
Reviewed-on: https://chromium-review.googlesource.com/940780
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539717}
[modify] https://crrev.com/51935a939ac01a2b974b13836bc9d4061ab33e42/services/ui/ws/display_manager.cc
[modify] https://crrev.com/51935a939ac01a2b974b13836bc9d4061ab33e42/services/ui/ws/window_tree.cc

Comment 4 by msw@chromium.org, Mar 14 2018

Blockedon: 682402
This is semi-blocked on being able to change settings in chrome:settings/display.
 Issue 682402  tracks system display extension api mash support (via DisplayInfoProvider[ChromeOS]/DisplayController).
I might be able to make some headway there myself, if no one is currently looking at that.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffc48921fecbba1abfa29158bb53f23f7765086c

commit ffc48921fecbba1abfa29158bb53f23f7765086c
Author: Mike Wasserman <msw@chromium.org>
Date: Fri Mar 23 16:59:52 2018

mash: Implement basic display mirroring in the Window Service.

Add PlatformDisplayMirror to represent mirroring destination displays.
Have ws::DisplayManager own and manage the mirrors as directed by Ash.
Add DisplayManager::OnFirstSurfaceActivation helper to notify mirrors.
Add FrameGenerator::scale_and_center_ behavior for mirror displays.

Minor cleanup and invert a broken conditional in ws::Display.

Fix a PlatformDisplay test, add a CreatePlatformWindow helper.
Remove an OzonePlatform accessor, I'll fix the test separately.

TODO: Get Mash cursor mirroring enabled (via cursor compositing?)

Bug:  806318 , 732987 
Test: Ctrl+Shift+M toggles display mirroring in --enable-features=Mash
Change-Id: I43453a2b76c397a31ebdd8fae7c8fda6399fa4bd
Reviewed-on: https://chromium-review.googlesource.com/775653
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545489}
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/BUILD.gn
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/display.cc
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/display.h
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/display_manager.cc
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/display_manager.h
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/frame_generator.h
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display.cc
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display.h
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_default.cc
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_default_unittest.cc
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_delegate.h
[add] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_mirror.cc
[add] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_mirror.h
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/window_server.cc
[modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/ui/platform_window/platform_window.h

Labels: -Proj-Mustash-Mus-WS
Deprecating label Proj-Mustash-Mus-WS in favor of Components.
Labels: Proj-Mash
Status: WontFix (was: Started)
I think this bug is obsolete with the switch to ws2, please reopen if not.

Sign in to add a comment