Issue metadata
Sign in to add a comment
|
Add an ARIA label to buttons with visual only content |
||||||||||||||||||||||
Issue descriptionThere are a few cases in Chrome's UI when a button has a visual only / decorative label. For example, the "Remove" button in the Downloads page has an X as its contents. Since the accessibility logic determines that there is some textual contents in the button, it will use them as the accessibility label, even though the label might be meaningless to a visually impaired user. A better accessibility label in these cases might be the one provided by the title attribute. This should be more descriptive given its use as a tooltip. We need to modify our button implementation to use the contents of the title attribute as an ARIA label if one exists and if the button's actual label is decorative. See also the Polymer 2 migration bug: https://crbug.com/738611
,
Jan 26 2018
It's further worth mentioning that this UI has been in place since at least Chrome 55 so it's not considered to be a regression.
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c0dbe25a50aa420d01598317a91612b0a6bdce6 commit 5c0dbe25a50aa420d01598317a91612b0a6bdce6 Author: Nektarios Paisios <nektar@chromium.org> Date: Wed Feb 07 20:56:59 2018 Added an ARIA label to buttons with only visually meaningful contents Bug: 806317 R=dmazzoni@chromium.org, dtrainor@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3f563f02e201389e2fec63ec4230cad75bc7c265 Reviewed-on: https://chromium-review.googlesource.com/882103 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#535136} [modify] https://crrev.com/5c0dbe25a50aa420d01598317a91612b0a6bdce6/chrome/browser/resources/md_downloads/item.html |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nek...@chromium.org
, Jan 26 2018