New issue
Advanced search Search tips

Issue 806313 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 737629



Sign in to add a comment

OOP: Serialize bitmaps using the TransferCache.

Project Member Reported by khushals...@chromium.org, Jan 26 2018

Issue description

GpuImageDecodeCache does not take care of serializing bitmaps using the TransferCache for OOP raster. Without this, any op using bitmaps is broken.

Fixing this is going to be more involved, since bitmaps don't set a PaintImage::ContentId right now, which is necessary for keying them in the cache.
 
Components: Internals>Compositing>Rasterization

Comment 2 by enne@chromium.org, Feb 8 2018

Blocking: 737629
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73760a33887fc8333fe071dd0e5e8c17891e9518

commit 73760a33887fc8333fe071dd0e5e8c17891e9518
Author: Khushal <khushalsagar@chromium.org>
Date: Fri Feb 16 19:29:51 2018

cc: Serialize bitmap backed images for OOP raster.

Since non-lazy generated images in paint recordings bypass the image
cache in PlaybackImageProvider, we fail to serialize them in OOP raster.
This change adds support for maintaining the uploads for these images in
the GPU cache and serializing them for OOP.

R=ericrk@chromium.org

Bug:  806313 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1a084b69957d6e3ab74a4e03627d9c5026df1e3e
Reviewed-on: https://chromium-review.googlesource.com/912692
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537379}
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/layers/picture_image_layer_unittest.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/paint/paint_image.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/paint/paint_image.h
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/paint/paint_image_builder.h
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/paint/scoped_raster_flags.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/raster/playback_image_provider.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/raster/playback_image_provider_unittest.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/test/fake_content_layer_client.h
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/test/skia_common.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/test/skia_common.h
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/tiles/gpu_image_decode_cache.h
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/tiles/image_controller_unittest.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/tiles/software_image_decode_cache.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/tiles/software_image_decode_cache_perftest.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/trees/image_animation_controller.h
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/trees/layer_tree_host_pixeltest_blending.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/media/renderers/paint_canvas_video_renderer.cc
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/third_party/WebKit/Source/platform/DragImage.cpp
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/third_party/WebKit/Source/platform/DragImageTest.cpp
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/third_party/WebKit/Source/platform/graphics/UnacceleratedStaticBitmapImage.cpp
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/third_party/WebKit/Source/platform/graphics/filters/PaintFilterBuilder.cpp
[modify] https://crrev.com/73760a33887fc8333fe071dd0e5e8c17891e9518/ui/gfx/skia_paint_util.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35cdc727373d49f2ac322c70e94c57bc7e09248a

commit 35cdc727373d49f2ac322c70e94c57bc7e09248a
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Feb 22 02:11:39 2018

gpu_pixel_test: Re-enable rebaselined css filter pixel tests.

R=piman@chromium.org

Bug:  806313 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia2437f7cb0a2841b30887bcd4bffd579269537b4
Reviewed-on: https://chromium-review.googlesource.com/927209
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538316}
[modify] https://crrev.com/35cdc727373d49f2ac322c70e94c57bc7e09248a/content/test/gpu/gpu_tests/pixel_expectations.py

Status: Fixed (was: Assigned)

Sign in to add a comment