New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806311 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Surface update errors to moblab UI

Project Member Reported by mattmallett@chromium.org, Jan 26 2018

Issue description

When updating the moblab version through the UI, we should surface any error, so the user has some indication that the update failed.

 
Status: Available (was: Untriaged)
Owner: mattmallett@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1674447ddd7815b1ac463a37084afbbcc8ea86e1

commit 1674447ddd7815b1ac463a37084afbbcc8ea86e1
Author: Matt Mallett <mattmallett@chromium.org>
Date: Fri Feb 09 00:37:02 2018

[moblab] Show update errors on UI

If a user requests an update from the UI, and the update fails,
surface the error to the UI.

BUG= chromium:806311 
TEST=test on local moblab, forced an update error by setting the
omaha url to an unresolvable address

Change-Id: I425a8013a1df1e09f9a8e8b821f5afb76496eb58
Reviewed-on: https://chromium-review.googlesource.com/909330
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/1674447ddd7815b1ac463a37084afbbcc8ea86e1/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/1674447ddd7815b1ac463a37084afbbcc8ea86e1/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 12 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/152bb6a7e88f47e5264f83dc61a5d2ef43ea150a

commit 152bb6a7e88f47e5264f83dc61a5d2ef43ea150a
Author: Matt Mallett <mattmallett@chromium.org>
Date: Mon Feb 12 21:00:32 2018

[moblab] Show update errors on UI

If a user requests an update from the UI, and the update fails,
surface the error to the UI.

BUG= chromium:806311 
TEST=test on local moblab, forced an update error by setting the
omaha url to an unresolvable address

Change-Id: I425a8013a1df1e09f9a8e8b821f5afb76496eb58
Reviewed-on: https://chromium-review.googlesource.com/909330
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 1674447ddd7815b1ac463a37084afbbcc8ea86e1)
Reviewed-on: https://chromium-review.googlesource.com/912172
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/152bb6a7e88f47e5264f83dc61a5d2ef43ea150a/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/152bb6a7e88f47e5264f83dc61a5d2ef43ea150a/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 12 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b22e73bc0f7f5750fcd6aca0802fdc45820bc658

commit b22e73bc0f7f5750fcd6aca0802fdc45820bc658
Author: Matt Mallett <mattmallett@chromium.org>
Date: Mon Feb 12 21:00:34 2018

[moblab] Show update errors on UI

If a user requests an update from the UI, and the update fails,
surface the error to the UI.

BUG= chromium:806311 
TEST=test on local moblab, forced an update error by setting the
omaha url to an unresolvable address

Change-Id: I425a8013a1df1e09f9a8e8b821f5afb76496eb58
Reviewed-on: https://chromium-review.googlesource.com/909330
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 1674447ddd7815b1ac463a37084afbbcc8ea86e1)
Reviewed-on: https://chromium-review.googlesource.com/912173
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/b22e73bc0f7f5750fcd6aca0802fdc45820bc658/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/b22e73bc0f7f5750fcd6aca0802fdc45820bc658/frontend/afe/moblab_rpc_interface.py

Status: Fixed (was: Started)

Sign in to add a comment