Need unit test for voice input button being absent in text entry field in incognito mode |
|||||
Issue descriptionThe current manual test case is: Voice input button is absent in text entry field in incognito mode 1. Open website in incognito mode in 2D Clank, Enter Chrome VR 2. Click URL area in omnibox to switch to “omnibox text entry mode” 3. Make sure voice input button is absent in text entry field
,
Jan 29 2018
Funny, adding this test inadvertently found another bug: As of now, typed text in the omnibox disappears under the voice button if it extends that far. Most users won't see this as they wouldn't fill the field. A separate bug has been filed.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/185f9b627390a793688e56735223f0611c9a873b commit 185f9b627390a793688e56735223f0611c9a873b Author: Christopher Grant <cjgrant@chromium.org> Date: Mon Jan 29 18:19:02 2018 VR: Add unit test for omnibox voice search button visibility As requested by the test team, this will eliminate a manual test case. BUG= 806279 R=ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5e08e7b8e30e65cebf680d3449d15a0b293de7b1 Reviewed-on: https://chromium-review.googlesource.com/890392 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#532497} [modify] https://crrev.com/185f9b627390a793688e56735223f0611c9a873b/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/185f9b627390a793688e56735223f0611c9a873b/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/185f9b627390a793688e56735223f0611c9a873b/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/185f9b627390a793688e56735223f0611c9a873b/chrome/browser/vr/ui_unittest.cc
,
Jan 29 2018
,
Jan 29 2018
@dbbrooks - Could you please sniff at the test and make sure it does what you want? Thanks!
,
Feb 8 2018
,
Mar 8 2018
Verified in the ui_unittest.cc that the requested scenario is covered. Closing as Verified.
,
Jul 4
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cjgrant@chromium.org
, Jan 29 2018Owner: cjgrant@chromium.org
Status: Started (was: Untriaged)