New issue
Advanced search Search tips

Issue 806274 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Have the tap on the button recording metrics and unfocusing the omnibox

Project Member Reported by gambard@chromium.org, Jan 26 2018

Issue description

See description.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e943dacd96d9ba259c94a7dbefb47c5c5241c31

commit 7e943dacd96d9ba259c94a7dbefb47c5c5241c31
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 31 10:32:57 2018

Add standard action to toolbar buttons

This CL adds the standard actions (cancelling omnibox edit and
recording metrics) to all the toolbar buttons.

Bug:  806274 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifbc108f852ae5f521343f3ea8065a8637c8afb68
Reviewed-on: https://chromium-review.googlesource.com/893266
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533245}
[modify] https://crrev.com/7e943dacd96d9ba259c94a7dbefb47c5c5241c31/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm
[modify] https://crrev.com/7e943dacd96d9ba259c94a7dbefb47c5c5241c31/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view.h
[modify] https://crrev.com/7e943dacd96d9ba259c94a7dbefb47c5c5241c31/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/7e943dacd96d9ba259c94a7dbefb47c5c5241c31/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/7e943dacd96d9ba259c94a7dbefb47c5c5241c31/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/7e943dacd96d9ba259c94a7dbefb47c5c5241c31/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_coordinator.mm
[modify] https://crrev.com/7e943dacd96d9ba259c94a7dbefb47c5c5241c31/tools/metrics/actions/actions.xml

Status: Fixed (was: Assigned)

Sign in to add a comment