Enable live editing/hot reloading of ES6 modules
Reported by
herr.er...@gmail.com,
Jan 26 2018
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 Steps to reproduce the problem: 1. Add and map source files (like JS) in work space 2. Edit JS function in Source panel or external editor 3. What is the expected behavior? Function body gets hot-swapped/replaced What went wrong? Console prints "LiveEdit failed: Editing module's script is not supported." Did this work before? N/A Chrome version: 63.0.3239.132 Channel: n/a OS Version: OS X 10.13.3 Flash Version: For some small projects I use a custom workflow which doesn't rely on a builder/watcher. When adding the files to workspace, Chrome automatically reloaded JS code before (with <script src> or AMD), which was quite nice. Unfortunately, this doesn't work with ES6 modules, but this would be great if it could work too.
,
Jan 31 2018
Thanks for the report. Assigning to kozy@, since the comment's source has a TODO(kozy).
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/0cec56a4099d00e7ff0f67653d809b75e353703a commit 0cec56a4099d00e7ff0f67653d809b75e353703a Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Sep 21 19:49:16 2018 inspector: allow es6 module liveedit After total liveedit rewrite, liveedit works with module, we can remove the guard. R=dgozman@chromium.org Bug: chromium:806261 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ide15eca2ab6d8ba7df4e7fae541c4a65794eeea8 Reviewed-on: https://chromium-review.googlesource.com/1238914 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56151} [modify] https://crrev.com/0cec56a4099d00e7ff0f67653d809b75e353703a/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/0cec56a4099d00e7ff0f67653d809b75e353703a/src/inspector/v8-debugger-script.cc [add] https://crrev.com/0cec56a4099d00e7ff0f67653d809b75e353703a/test/inspector/debugger/es6-module-liveedit-expected.txt [add] https://crrev.com/0cec56a4099d00e7ff0f67653d809b75e353703a/test/inspector/debugger/es6-module-liveedit.js [delete] https://crrev.com/1e6d96074bda2f8e3f3fee429a705d8b53927db0/test/inspector/debugger/es6-module-set-script-source-expected.txt [delete] https://crrev.com/1e6d96074bda2f8e3f3fee429a705d8b53927db0/test/inspector/debugger/es6-module-set-script-source.js
,
Sep 21
|
|||
►
Sign in to add a comment |
|||
Comment 1 by krajshree@chromium.org
, Jan 29 2018