New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806247 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

:first-line selector breaks ::placeholder styling

Reported by ferdy.ch...@gmail.com, Jan 26 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36

Steps to reproduce the problem:
See codepen:
https://codepen.io/fchristant/pen/EoqXRw

When styling the :first-line selector, ::placeholder styling is simply ignored. The demo shows that the placeholder text does not turn red.

Remove the first-line selector, and the placeholder styling works.

It does not seem to matter what is set inside :first-line, even completely unrelated declarations will block ::placeholder styles from being applied.

What is the expected behavior?
::placeholder styling should work as these two selectors seem completely unrelated.

What went wrong?
::placeholder styling is ignored

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 64.0.3282.119  Channel: stable
OS Version: 10.0
Flash Version:
 
Note, this declaration:

input:first-line {
  display:inline-block;
}

Is a relatively popular hack to harmonize line height for input elements across browsers. Possibly, it's a default rule in some frameworks.
Labels: Needs-Triage-M64

Comment 3 by cnardi@chromium.org, Jan 27 2018

Components: Blink>CSS
Status: Untriaged (was: Unconfirmed)
Confirmed on M65 as well.
Labels: M-64 M-65 Needs-Bisect
Able to reproduce the issue on reported chrome version 64.0.3282.119 and on the latest chrome version 66.0.3334.0 using Windows 10, Ubuntu 14.04 and Mac 10.12.6. As the issue is seen from M60(60.0.3072.0) considering it as non-regression and marking it as Untriaged.

Thanks!
Cc: viswatej...@techmahindra.com
Labels: -Needs-Bisect Triaged-ET M-66 FoundIn-66 Target-66 OS-Linux OS-Mac
Status: Available (was: Untriaged)
Labels: Hotlist-Interop

Comment 9 by cnardi@chromium.org, May 15 2018

Cc: cnardi@chromium.org
Status: Fixed (was: Available)
Interestingly enough, this appears to no longer reproduce on M68 (latest dev). Marking this as fixed for now (unless it actually isn't fixed), but perhaps we should add a test to make sure this doesn't regress?
Confirmed that this looks fixed, tried on Canary 68.
Project Member

Comment 12 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01dda9ad5c2ad56e20b024b333cf653fb2fad066

commit 01dda9ad5c2ad56e20b024b333cf653fb2fad066
Author: Chris Nardi <cnardi@chromium.org>
Date: Thu May 24 16:47:41 2018

Add regression test for ::first-line breaking ::placeholder styles

A bug was reported where ::first-line broke ::placeholder styling, which
seems to have been fixed in https://crrev.com/550589. However, we don't
currently have a test for this bug. Add in a test to make sure we don't
regress with this bug.

Bug:  806247 
Change-Id: I5bbcda1ccf5b3ea08a7b66a68071a802f42e9228
Reviewed-on: https://chromium-review.googlesource.com/1071126
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561526}
[add] https://crrev.com/01dda9ad5c2ad56e20b024b333cf653fb2fad066/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-line-and-placeholder-ref.html
[add] https://crrev.com/01dda9ad5c2ad56e20b024b333cf653fb2fad066/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-line-and-placeholder.html

Sign in to add a comment