New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806242 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.5%-21.6% regression in thread_times.key_silk_cases at 531700:531788

Project Member Reported by primiano@chromium.org, Jan 26 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 26 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=806242

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=caca0dd8a6e0207a0b3aab641ec5eafd88d08da7b2ba4be77ffdd21266b83fe5


Bot(s) for this bug's original alert(s):

android-one
android-webview-nexus6
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 26 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/107dd992840000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 27 2018

Cc: danakj@chromium.org bsalomon@chromium.org torne@chromium.org
Owner: torne@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/107dd992840000

Revert "Use new Skia resource purging API when we go idle"
By torne@chromium.org ยท Wed Jan 24 22:03:51 2018
chromium @ 1fd722308b8c3d4533b19ad2df5d40752e945e01

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Components: Internals>GPU>Metrics

Comment 5 by torne@chromium.org, Mar 19 2018

Cc: -torne@chromium.org
Owner: ericrk@chromium.org
ericrk@, this bisect pointed out my sheriff revert of your change - handing this to you to take a look, since I have no idea (and didn't notice this for some time, whoops)

Comment 6 by ericrk@chromium.org, Apr 18 2018

Status: WontFix (was: Assigned)
My change had a bug which caused us to preserve caches longer than intended. It makes sense that reverting it (and throwing out caches) would result in more work in certain cases. I'm not too concerned as all the "regressions were just bringing us back to the previous levels before my buggy CL landed.

Sign in to add a comment