Issue metadata
Sign in to add a comment
|
BookmarkTest#testSearchBookmarks fails on Android N
Reported by
mirko.r...@mips.com,
Jan 26 2018
|
||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Use larger tablet (MINIMUM_LARGE_TABLET_WIDTH_DP = 720) 2. ./out/Release/bin/run_chrome_public_test_apk -f org.chromium.chrome.browser.bookmarks.BookmarkTest#testSearchBookmarks* What is the expected behavior? Test to pass What went wrong? Tests failed: C 45.396s Main Detailed Logs C 45.396s Main ******************************************************************************** C 45.396s Main [FAIL] org.chromium.chrome.browser.bookmarks.BookmarkTest#testSearchBookmarks: C 45.396s Main java.lang.AssertionError: Wrong number of items before starting search. expected:<4> but was:<3> C 45.396s Main at org.junit.Assert.fail(Assert.java:88) C 45.396s Main at org.junit.Assert.failNotEquals(Assert.java:834) C 45.396s Main at org.junit.Assert.assertEquals(Assert.java:645) C 45.396s Main at org.chromium.chrome.browser.bookmarks.BookmarkTest.assertBookmarkItems(BookmarkTest.java:464) C 45.396s Main at org.chromium.chrome.browser.bookmarks.BookmarkTest.testSearchBookmarks(BookmarkTest.java:285) Did this work before? Yes Chrome version: Top of master Channel: n/a OS Version: 7.1.1 Flash Version: The tests asserts on devices which are recognized as LargeTablet due to https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java?q=BookmarkTest.java:464+file:%5Esrc/+package:%5Echromium$&l=457 This +1 was added last year in change https://codereview.chromium.org/2800763002 However large tablet style has been modified to match mobile style here https://codereview.chromium.org/2837643002 but the test cases from BookmarkTest.java have not been modified accordingly.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb6b8b29f4cc4d1d06cffd39a37a392683812389 commit fb6b8b29f4cc4d1d06cffd39a37a392683812389 Author: Mirko Raus <mirko.raus@mips.com> Date: Mon Jan 29 17:44:26 2018 [Bookmarks] Fix Bookmark tests for large tablets With tablet style Bookmarks modified in: https://codereview.chromium.org/2837643002 Bookmarks tests need to be modified. Bug: 806217 Change-Id: I761e7fdade7a311d65b4411be2d98b3cffe071d0 Reviewed-on: https://chromium-review.googlesource.com/889338 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532478} [modify] https://crrev.com/fb6b8b29f4cc4d1d06cffd39a37a392683812389/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java
,
Jan 30 2018
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by mirko.r...@mips.com
, Jan 26 2018