New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 26
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Pre-CQ Uprev stage fails on cros_mark_as_stable

Project Member Reported by nya@chromium.org, Jan 26

Issue description

In pre-CQ, Uprev stage fails on running cros_mark_as_stable. It's complaining third_party/libapps/nassh/manifest.json is missing.


Example pre-CQ run:

https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/79065


Example failure log:

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromiumos.tryserver%2Fpre_cq%2F79065%2F%2B%2Frecipes%2Fsteps%2FUprev%2F0%2Fstdout

00:32:19: ERROR: Package crosh-extension chromeos-version.sh failed: return code: 2; command: /b/c/cbuild/repository/src/third_party/chromiumos-overlay/chromeos-base/crosh-extension/files/chromeos-version.sh /b/c/cbuild/repository/src/third_party/libapps
gawk: fatal: cannot open file `/b/c/cbuild/repository/src/third_party/libapps/nassh/manifest.json' for reading (No such file or directory)
cmd=['/b/c/cbuild/repository/src/third_party/chromiumos-overlay/chromeos-base/crosh-extension/files/chromeos-version.sh', '/b/c/cbuild/repository/src/third_party/libapps']
00:32:19: ERROR: 
return code: 1; command: /b/c/cbuild/repository/chromite/bin/cros_mark_as_stable --all '--boards=' '--overlays=...', '--drop_file=/b/c/cbuild/repository/src/scripts/cbuildbot_package.list', 'commit'], cwd=/b/c/cbuild/repository
00:32:19: ERROR: /b/c/cbuild/repository/chromite/bin/cros_mark_as_stable failed (code=1)


I guess this change is the culprit:

https://chromium-review.googlesource.com/c/apps/libapps/+/832675

 
Cc: marcochen@chromium.org shapiroc@chromium.org bmgordon@chromium.org
+sheriffs

Cc: vapier@chromium.org
Owner: ----
Status: Available (was: Assigned)
Labels: -Pri-1 Pri-0
Owner: vapier@chromium.org
Status: Assigned (was: Available)
The CL renames manifest.json, not good.

Revert is here: https://chromium-review.googlesource.com/c/apps/libapps/+/888339
Just find the same root cause of last build and thanks for filing the issue and creating revert CL.
Implemented the recommended forward fix in the revert cl:
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/887976
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/907862fd7223303706dc48a4c6ed484d8de365d0

commit 907862fd7223303706dc48a4c6ed484d8de365d0
Author: C Shapiro <shapiroc@chromium.org>
Date: Fri Jan 26 15:29:12 2018

Fix build failure caused by rename

This is an attempt to forward fix the issue crrev.com/c/832675 by fixing
the filename to the renamed file.

BUG= chromium:806196 
TEST=cros tryjob -g 887976 reef-pre-cq

Change-Id: I22c39abe1f28d384a28d6b048f215a2c7db43313
Reviewed-on: https://chromium-review.googlesource.com/887976
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/907862fd7223303706dc48a4c6ed484d8de365d0/chromeos-base/crosh-extension/files/chromeos-version.sh

Status: Fixed (was: Assigned)
Charles's CL fixed things

Sign in to add a comment