New issue
Advanced search Search tips

Issue 806165 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Print panel UI tips is wrong

Reported by madux...@gmail.com, Jan 26 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce the problem:
1. open a web page
2. `ctrl + p` to open the print setting panel
3. set the page number range: 1-5、8

What is the expected behavior?
my input should pass the validate.

What went wrong?
an error tips appear ,bug what I inputed is match the tips rule.

Did this work before? No 

Chrome version: 63.0.3239.132  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

- I'm use Chinese Language in chrome.
- In Chinese, `,` and `、`is different, the tips may use `,`
- the same issue is in 66.0.3331.0(stable)canary (64 bit)
 
chrome-print-tips-bug.png
30.7 KB View Download
Labels: Needs-Triage-M63
Components: UI>Browser>PrintPreview
Labels: Triaged-ET M-66 FoundIn-66 Target-66 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 63.0.3239.132 and on the latest chrome version 66.0.3350.0 using Windows-10, Mac 10.12.6 and Ubuntu 14.04. As the issue is seen from M60(60.0.3072.0) considering it as non-regression and marking it as Untriaged.

Thanks!
Components: -UI UI>Internationalization
Labels: -Pri-2 OS-Chrome Pri-3
Status: Available (was: Untriaged)
We should into accepting '、' and other comma variants as valid input.
Owner: thestig@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/930465 hopefully
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fa294ea928c8a7df6b43952d7c6f2b0deff0915

commit 2fa294ea928c8a7df6b43952d7c6f2b0deff0915
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Feb 22 20:18:13 2018

Print Preview: Allow ideographic comma in page range field.

BUG= 806165 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I85a53589ecb372ec608929e85ea7657e68b77a6a
Reviewed-on: https://chromium-review.googlesource.com/930465
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538543}
[modify] https://crrev.com/2fa294ea928c8a7df6b43952d7c6f2b0deff0915/chrome/browser/resources/print_preview/print_preview_utils.js
[modify] https://crrev.com/2fa294ea928c8a7df6b43952d7c6f2b0deff0915/chrome/browser/resources/print_preview/print_preview_utils_unittest.gtestjs

Status: Fixed (was: Started)

Sign in to add a comment