Blink IDL compiler should ignore HTMLConstructor extended attribute |
||||
Issue description
When adding HTMLConstructor extend attribute to interface statement, e.g.
[HTMLConstructor]
interface HTMLInputElement : HTMLELement {
...
}
Following compilation error occurred:
gen/blink/bindings/modules/v8/V8ContextSnapshotExternalReferences.cpp(1062,60): error: no member named 'constructorCallback' in 'blink::V8HTMLCanvasElementPartial'
reinterpret_cast<intptr_t>(V8HTMLCanvasElementPartial::constructorCallback),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
gen/blink/bindings/modules/v8/V8ContextSnapshotExternalReferences.cpp(1087,60): error: no member named 'constructorCallback' in 'blink::V8HTMLIFrameElementPartial'
reinterpret_cast<intptr_t>(V8HTMLIFrameElementPartial::constructorCallback),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
gen/blink/bindings/modules/v8/V8ContextSnapshotExternalReferences.cpp(1090,59): error: no member named 'constructorCallback' in 'blink::V8HTMLInputElementPartial'
reinterpret_cast<intptr_t>(V8HTMLInputElementPartial::constructorCallback),
~~~~~~~~~~~~~~~~~~~~~~~~~~~^
gen/blink/bindings/modules/v8/V8ContextSnapshotExternalReferences.cpp(1135,59): error: no member named 'constructorCallback' in 'blink::V8HTMLVideoElementPartial'
reinterpret_cast<intptr_t>(V8HTMLVideoElementPartial::constructorCallback),
~~~~~~~~~~~~~~~~~~~~~~~~~~~^
,
Jan 26 2018
Peria-san, would you mind taking a look at this? Should we raise the priority of the issue 805326 if this needs to be P1 issue? Or making this P2 makes sense?
,
Jan 26 2018
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6221aaaaddf73fff3a7532fdbdc1783c06cc5b5 commit c6221aaaaddf73fff3a7532fdbdc1783c06cc5b5 Author: Hitoshi Yoshida <peria@chromium.org> Date: Fri Jan 26 22:52:56 2018 bindings: Do not refer partial interfaces' constructors Partial interfaces do not have constructors, so we can't nominate them as members of V8ContextSnapshotExternalReferences. Bug: 806163 Change-Id: I28e20fac326d57851f6443cca7c0c53bc86680fb Reviewed-on: https://chromium-review.googlesource.com/888181 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#532081} [modify] https://crrev.com/c6221aaaaddf73fff3a7532fdbdc1783c06cc5b5/third_party/WebKit/Source/bindings/scripts/generate_v8_context_snapshot_external_references.py
,
Jan 29 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yosin@chromium.org
, Jan 26 2018