New issue
Advanced search Search tips

Issue 806145 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix UpdateCheckerTests

Project Member Reported by sorin@chromium.org, Jan 26 2018

Issue description

In a couple of UpdateCheckerTests, multiple update checks are triggered in the same test and a url post interceptor is used to inspect the requests.

Once an expectation for the url post interceptor is matched, it is removed from the interceptor queue. However, the tests don't create new expectations as the tests are making progress. Therefore, subsequent requests don't have expectations to match. As a side effect, for an unknown reason, the calls where no expection is set take about 1000 ms each to complete, and thus, the test execution takes ~10 seconds to run
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f78403c6be3e82fb685259740e81967c308738c3

commit f78403c6be3e82fb685259740e81967c308738c3
Author: Sorin Jianu <sorin@chromium.org>
Date: Sat Jan 27 00:04:50 2018

Fix UpdateCheckerTests.

Bug:  806145 
Change-Id: Ia3348c5f9c1c589d805fb583890169dc38516e39
Reviewed-on: https://chromium-review.googlesource.com/888160
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532095}
[modify] https://crrev.com/f78403c6be3e82fb685259740e81967c308738c3/components/update_client/update_checker_unittest.cc

Comment 2 by sorin@chromium.org, Feb 1 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment