lucifer job_aborter behaves wrong on drones |
|||||
Issue descriptionjob_aborter works fine on shards and in the future drone++ but it does not work well on master + drones currently. It did in the original design, but not after a few iterations weeding out other race conditions. Briefly, job_aborter is checking against the database for outstanding jobs and on the local filesystem for lock files indicating whether the job process is still holding the lock. Drones all check the shared master database against their local filesystem for crashed jobs.
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2e4dd10387d69bb1115260a55115d817da869247 commit 2e4dd10387d69bb1115260a55115d817da869247 Author: Allen Li <ayatane@chromium.org> Date: Tue Jan 30 20:21:48 2018 [autotest] Add drone field to JobHandoff model BUG= chromium:806128 TEST=None Change-Id: I5873942c20a1d54eb8f9a20a1aa95f8a8de9a054 Reviewed-on: https://chromium-review.googlesource.com/890104 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/2e4dd10387d69bb1115260a55115d817da869247/frontend/afe/models.py
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c224008dfbba6fd18db74253805fa338cb6d8017 commit c224008dfbba6fd18db74253805fa338cb6d8017 Author: Allen Li <ayatane@chromium.org> Date: Wed Jan 31 00:14:09 2018 Revert "[autotest] Add drone field to JobHandoff model" This reverts commit 2e4dd10387d69bb1115260a55115d817da869247. Reason for revert: <INSERT REASONING HERE> Original change's description: > [autotest] Add drone field to JobHandoff model > > BUG= chromium:806128 > TEST=None > > Change-Id: I5873942c20a1d54eb8f9a20a1aa95f8a8de9a054 > Reviewed-on: https://chromium-review.googlesource.com/890104 > Commit-Ready: Allen Li <ayatane@chromium.org> > Tested-by: Allen Li <ayatane@chromium.org> > Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Bug: chromium:806128 Change-Id: I1a0026b354c805f3df594c915ac56d19aa61d676 Reviewed-on: https://chromium-review.googlesource.com/894823 Reviewed-by: Jacob Kopczynski <jkop@chromium.org> Tested-by: Jacob Kopczynski <jkop@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Commit-Queue: Allen Li <ayatane@chromium.org> Commit-Queue: Jacob Kopczynski <jkop@chromium.org> Trybot-Ready: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/c224008dfbba6fd18db74253805fa338cb6d8017/frontend/afe/models.py
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1fc27d37218eb3ace5e5dad394b974a808d81d4d commit 1fc27d37218eb3ace5e5dad394b974a808d81d4d Author: Allen Li <ayatane@chromium.org> Date: Thu Feb 01 05:24:25 2018 [autotest] Add drone field to JobHandoff model BUG= chromium:806128 TEST=None Change-Id: I814bc4aeb0ea100a5cd524091a9905f2172c6b54 Reviewed-on: https://chromium-review.googlesource.com/894739 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/1fc27d37218eb3ace5e5dad394b974a808d81d4d/frontend/afe/models.py
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b07ab0ffc207e40b235e6955b0c6a6b614426dc8 commit b07ab0ffc207e40b235e6955b0c6a6b614426dc8 Author: Allen Li <ayatane@chromium.org> Date: Thu Feb 01 22:02:29 2018 [autotest] Add drone tracking to lucifer handoff BUG= chromium:806128 TEST=None Change-Id: I4205e22fc74d7b5e5a3c1ebe83d8a721648e6055 Reviewed-on: https://chromium-review.googlesource.com/890105 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/b07ab0ffc207e40b235e6955b0c6a6b614426dc8/scheduler/luciferlib.py [modify] https://crrev.com/b07ab0ffc207e40b235e6955b0c6a6b614426dc8/scheduler/monitor_db.py
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/580468787a8533b458c9164a588da3ec949639bb commit 580468787a8533b458c9164a588da3ec949639bb Author: Allen Li <ayatane@chromium.org> Date: Tue Feb 13 01:05:15 2018 [autotest] Only abort lucifer jobs for the current drone BUG= chromium:806128 TEST=None Change-Id: Ia850ebc1dd864e6d8ec874ab771307950d6a2b81 Reviewed-on: https://chromium-review.googlesource.com/891581 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/580468787a8533b458c9164a588da3ec949639bb/venv/lucifer/handoffs.py
,
Feb 14 2018
,
Feb 15 2018
,
Feb 15 2018
priority inheritance. so is it safe to just revert https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/891581 ?
,
Feb 16 2018
Other bug is tracking follow up |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 29 2018