New issue
Advanced search Search tips

Issue 806119 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

termina: lxd integration

Project Member Reported by smbar...@chromium.org, Jan 26 2018

Issue description

Integrate lxd into VM startup.
 
Labels: Proj-Containers
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a02292bb526614bf585bad4232cb0b4e8423711c

commit a02292bb526614bf585bad4232cb0b4e8423711c
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 01 02:00:57 2018

termina: add termina-lxd-scripts package

BUG= chromium:806119 
TEST=./build_packages --board=tatl --nowithautotest

Change-Id: I9d5b18a2c4f1098a50e0260e9c945d3060a96951
Reviewed-on: https://chromium-review.googlesource.com/890119
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[add] https://crrev.com/a02292bb526614bf585bad4232cb0b4e8423711c/project-termina/chromeos-base/termina-lxd-scripts/termina-lxd-scripts-0.0.1-r1.ebuild
[modify] https://crrev.com/a02292bb526614bf585bad4232cb0b4e8423711c/project-termina/virtual/target-termina-os/target-termina-os-1.5.ebuild
[add] https://crrev.com/a02292bb526614bf585bad4232cb0b4e8423711c/project-termina/chromeos-base/termina-lxd-scripts/files/stateful_setup.sh
[add] https://crrev.com/a02292bb526614bf585bad4232cb0b4e8423711c/project-termina/chromeos-base/termina-lxd-scripts/files/lxd_setup.sh
[rename] https://crrev.com/a02292bb526614bf585bad4232cb0b4e8423711c/project-termina/virtual/target-termina-os/target-termina-os-1.5-r10.ebuild
[add] https://crrev.com/a02292bb526614bf585bad4232cb0b4e8423711c/project-termina/chromeos-base/termina-lxd-scripts/termina-lxd-scripts-0.0.1.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/bbd56222bb37caccb4dfdda84b6c609b339ea999

commit bbd56222bb37caccb4dfdda84b6c609b339ea999
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 01 02:01:02 2018

CHROMIUM: arch: x86: configs: renormalize VM config

BUG= chromium:806119 
TEST=emerge-tatl chromeos-kernel-4_14

Change-Id: I74d49d6d23c185dd0746a7dfbb26206d10fc2f5a
Reviewed-on: https://chromium-review.googlesource.com/894665
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/bbd56222bb37caccb4dfdda84b6c609b339ea999/arch/x86/configs/chromiumos-container-vm-x86_64_defconfig

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/876be7459dd989515bb2069ad41d75610cd8a37d

commit 876be7459dd989515bb2069ad41d75610cd8a37d
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 01 22:55:22 2018

CHROMIUM: arch: x86: configs: enable BTRFS for VMs

BTRFS is used as the backend for the storage pool in lxd.

BUG= chromium:806119 
TEST=mount btrfs in tatl

Change-Id: Ief38c64be0cb4199541a27b43f05b61570e5912f
Reviewed-on: https://chromium-review.googlesource.com/894666
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/876be7459dd989515bb2069ad41d75610cd8a37d/arch/x86/configs/chromiumos-container-vm-x86_64_defconfig

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/19e57b9532f9be830fab7fad685957afc8f5ab78

commit 19e57b9532f9be830fab7fad685957afc8f5ab78
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Feb 02 05:29:32 2018

qcow_utils: add pkgconfig script

Add a pkgconfig file and script to fix it up at build time.

Also fix extern "C" for the qcow_utils header.

BUG= chromium:806119 
TEST=emerge-eve-kvm crosvm

Change-Id: Ib69d9e88b42d2f2c8661798c37537a4236e0506e
Reviewed-on: https://chromium-review.googlesource.com/891572
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/19e57b9532f9be830fab7fad685957afc8f5ab78/qcow_utils/platform2_preinstall.sh
[add] https://crrev.com/19e57b9532f9be830fab7fad685957afc8f5ab78/qcow_utils/libqcow_utils.pc.in
[modify] https://crrev.com/19e57b9532f9be830fab7fad685957afc8f5ab78/qcow_utils/src/qcow_utils.h

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/61dfd0e2cdfbe7e59e80ed67997ba899e4be8c3a

commit 61dfd0e2cdfbe7e59e80ed67997ba899e4be8c3a
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Feb 02 21:19:13 2018

vm_concierge: add GetVmInfo and StartLxd

BUG= chromium:806119 
TEST=concierge_client --start_lxd
CQ-DEPEND=CL:889714

Change-Id: I2d9b51aa59e55c3c9ccaccc18b7e392f7063008e
Reviewed-on: https://chromium-review.googlesource.com/889918
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/61dfd0e2cdfbe7e59e80ed67997ba899e4be8c3a/dbus/vm_concierge/service.proto
[modify] https://crrev.com/61dfd0e2cdfbe7e59e80ed67997ba899e4be8c3a/dbus/vm_concierge/dbus-constants.h

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e5aea65644c462576362c36ca7c08babdcffc3f2

commit e5aea65644c462576362c36ca7c08babdcffc3f2
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Feb 02 21:19:08 2018

vm_tools: concierge: make mounting extra disks optional

BUG= chromium:806119 
TEST=use concierge_client with extra disk and no mount
CQ-DEPEND=CL:889918

Change-Id: Ib7e84340d275879411c60c7e03d1e52c0827d102
Reviewed-on: https://chromium-review.googlesource.com/889710
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/e5aea65644c462576362c36ca7c08babdcffc3f2/vm_tools/concierge/service.cc
[modify] https://crrev.com/e5aea65644c462576362c36ca7c08babdcffc3f2/vm_tools/concierge/client.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 2 2018

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/67101f0d8af1f553275bcda5d307c2d3323137df

commit 67101f0d8af1f553275bcda5d307c2d3323137df
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Feb 02 21:19:12 2018

vm_tools: concierge: add GetVmInfo

Add a dbus message to get information about a currently running VM.

BUG= chromium:806119 
TEST=concierge_client --get_vm_info
CQ-DEPEND=CL:889918

Change-Id: Ib84f715479c4d325b4edc474ada5e761251b5149
Reviewed-on: https://chromium-review.googlesource.com/889714
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/67101f0d8af1f553275bcda5d307c2d3323137df/vm_tools/concierge/service.h
[modify] https://crrev.com/67101f0d8af1f553275bcda5d307c2d3323137df/vm_tools/concierge/service.cc
[modify] https://crrev.com/67101f0d8af1f553275bcda5d307c2d3323137df/vm_tools/concierge/client.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8c9c34a01b6dfc217a29e9e9f24cee176c0e3c29

commit 8c9c34a01b6dfc217a29e9e9f24cee176c0e3c29
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Feb 02 21:19:10 2018

vm_tools: concierge: simplify running processes

Concierge generally doesn't care about why a process might fail to run
in a VM, and just wants to know if the operation completed successfully.
Since maitred already logs more detailed failures, simplify RunProcess
and StartProcess to simply return bools.

Also add a RunProcessWithTimeout method that accepts a custom timeout for
the process to exit.

BUG= chromium:806119 
TEST=unittests

Change-Id: Iccfd948b05cee5c7e6505c998390c7b8d9d412c6
Reviewed-on: https://chromium-review.googlesource.com/895264
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/8c9c34a01b6dfc217a29e9e9f24cee176c0e3c29/vm_tools/concierge/virtual_machine_unittest.cc
[modify] https://crrev.com/8c9c34a01b6dfc217a29e9e9f24cee176c0e3c29/vm_tools/concierge/virtual_machine.cc
[modify] https://crrev.com/8c9c34a01b6dfc217a29e9e9f24cee176c0e3c29/vm_tools/concierge/virtual_machine.h
[modify] https://crrev.com/8c9c34a01b6dfc217a29e9e9f24cee176c0e3c29/vm_tools/concierge/service.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/6f8ed9e1e5101226f018fd2beea6a9c88f2b58b5

commit 6f8ed9e1e5101226f018fd2beea6a9c88f2b58b5
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat Feb 03 07:53:36 2018

vm_concierge: add CreateDiskIamge

BUG= chromium:806119 
TEST=concierge_client --create_disk_image

Change-Id: I95cd24d35a543cf86cb12c80f78d59aad54a86f6
Reviewed-on: https://chromium-review.googlesource.com/895383
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/6f8ed9e1e5101226f018fd2beea6a9c88f2b58b5/dbus/vm_concierge/service.proto
[modify] https://crrev.com/6f8ed9e1e5101226f018fd2beea6a9c88f2b58b5/dbus/vm_concierge/dbus-constants.h

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4c70a26f1a330d885754c3d483fb726165e07a44

commit 4c70a26f1a330d885754c3d483fb726165e07a44
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat Feb 03 10:37:52 2018

vm_tools: install qcow_utils lib

BUG= chromium:806119 
TEST=build vm_tools with qcow_utils
CQ-DEPEND=CL:891572

Change-Id: I247d0a6134a0b35d0818ce2767e82298e5d11ea3
Reviewed-on: https://chromium-review.googlesource.com/891570
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/4c70a26f1a330d885754c3d483fb726165e07a44/chromeos-base/crosvm/crosvm-9999.ebuild
[modify] https://crrev.com/4c70a26f1a330d885754c3d483fb726165e07a44/chromeos-base/vm_tools/vm_tools-9999.ebuild

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4471a972ea5a8440178cfd276331e8c8449a3298

commit 4471a972ea5a8440178cfd276331e8c8449a3298
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat Feb 03 10:37:51 2018

vm_tools: concierge: add StartLxd

Add a dbus message to start lxd on a VM.

BUG= chromium:806119 
TEST=concierge_client --start_lxd
CQ-DEPEND=CL:889918

Change-Id: I4432501d022e8f2c75a3e381b9274f7917bc5cc5
Reviewed-on: https://chromium-review.googlesource.com/889715
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/4471a972ea5a8440178cfd276331e8c8449a3298/vm_tools/concierge/service.h
[modify] https://crrev.com/4471a972ea5a8440178cfd276331e8c8449a3298/vm_tools/concierge/service.cc
[modify] https://crrev.com/4471a972ea5a8440178cfd276331e8c8449a3298/vm_tools/concierge/client.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/dbe452b6e3c6ec5ee97f38b04580d32947cbead8

commit dbe452b6e3c6ec5ee97f38b04580d32947cbead8
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 08 09:23:44 2018

termina: add chronos to lxd group

chronos must be in the lxd group for unprivileged access to lxd.

BUG= chromium:806119 
TEST=chronos can use lxd on tatl
CQ-DEPEND=CL:894191

Change-Id: If39635ad47434fd76d48c1b2c69802b4b19b4512
Reviewed-on: https://chromium-review.googlesource.com/895051
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/dbe452b6e3c6ec5ee97f38b04580d32947cbead8/project-termina/profiles/base/accounts/group/lxd

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/79a152d42d5b7d83ad864fbb923fd739aed3f426

commit 79a152d42d5b7d83ad864fbb923fd739aed3f426
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 08 09:23:45 2018

add crosvm to daemon-store group

concierge needs access to /home/root/<hash>/crosvm, and thus needs to
be in the daemon-store group.

BUG= chromium:806119 
TEST=display-accts.py
CQ-DEPEND=CL:894192

Change-Id: I7cb12b6dbd84dcc53653ac97bc116da5a6693f61
Reviewed-on: https://chromium-review.googlesource.com/894193
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/79a152d42d5b7d83ad864fbb923fd739aed3f426/profiles/base/accounts/group/daemon-store

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/616f4d33d4b360a978e9f972625c68d775d3d4c4

commit 616f4d33d4b360a978e9f972625c68d775d3d4c4
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 08 09:23:35 2018

vm_concierge: remove StartLxd in favor of a StartVm option

BUG= chromium:806119 
TEST=none
CQ-DEPEND=CL:895266

Change-Id: I866c90b121f463a8f9bca98779d233820aea4c9f
Reviewed-on: https://chromium-review.googlesource.com/905869
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/616f4d33d4b360a978e9f972625c68d775d3d4c4/dbus/vm_concierge/service.proto
[modify] https://crrev.com/616f4d33d4b360a978e9f972625c68d775d3d4c4/dbus/vm_concierge/dbus-constants.h

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b3bd13d887309fdfc6758a314d4d6da210d91aee

commit b3bd13d887309fdfc6758a314d4d6da210d91aee
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 08 09:23:43 2018

usergroup_baseline: add lxd for termina

termina boards will have an lxd user and group. chronos is expected to be in
the lxd group.

BUG= chromium:806119 
TEST=imagetest
CQ-DEPEND=CL:895051

Change-Id: I7f21b3acbced95efb6b37a4db3850fb9457867e2
Reviewed-on: https://chromium-review.googlesource.com/894191
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/b3bd13d887309fdfc6758a314d4d6da210d91aee/cros/test/usergroup_baseline.py

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/08f50c85ea24c2b1c66e754373655993e87fd52a

commit 08f50c85ea24c2b1c66e754373655993e87fd52a
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 08 09:23:46 2018

usergroup_baseline: add crosvm to daemon-store

crosvm will optionally store its stateful disk image under /home/root, which
requires the daemon-store group to access.

BUG= chromium:806119 
TEST=imagetest
CQ-DEPEND=CL:894193

Change-Id: I81497542e82015fbc2a47dafc81eae7e957544a8
Reviewed-on: https://chromium-review.googlesource.com/894192
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/08f50c85ea24c2b1c66e754373655993e87fd52a/cros/test/usergroup_baseline.py

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/10ed114343028a1167d26fc985720bfb68c4ee00

commit 10ed114343028a1167d26fc985720bfb68c4ee00
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 08 09:23:33 2018

vm_tools: concierge: add stateful/imageloader paths to jail

concierge will need access to /run/imageloader for VM rootfs/kernels, and
also needs /home for access to the LXD stateful disk image. Use a recursive
bind mount to add these paths.

BUG= chromium:806119 
TEST=vm_concierge service starts

Change-Id: I28b5e38264bb7b8029d0b101ba47bee137db6bf1
Reviewed-on: https://chromium-review.googlesource.com/895263
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/10ed114343028a1167d26fc985720bfb68c4ee00/vm_tools/init/vm_concierge.conf

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bc6e7ac2e9d68fed565ceeeb9956e8e50575251a

commit bc6e7ac2e9d68fed565ceeeb9956e8e50575251a
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Feb 08 09:23:37 2018

vm_tools: concierge: add command for starting termina vm

Remove StartLxdVm dbus method, and instead make it an option for
StartVm.

BUG= chromium:806119 
TEST=concierge_client --start_termina_vm=true --cryptohome_id=foo
CQ-DEPEND=CL:905869

Change-Id: Ib72fe2faebfce00c3bad4e0773e486103ca77d26
Reviewed-on: https://chromium-review.googlesource.com/895266
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/bc6e7ac2e9d68fed565ceeeb9956e8e50575251a/vm_tools/concierge/service.h
[modify] https://crrev.com/bc6e7ac2e9d68fed565ceeeb9956e8e50575251a/vm_tools/concierge/service.cc
[modify] https://crrev.com/bc6e7ac2e9d68fed565ceeeb9956e8e50575251a/vm_tools/concierge/client.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/8e3381b52a943d9da21c8534c0145714989a3186

commit 8e3381b52a943d9da21c8534c0145714989a3186
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Feb 09 07:42:37 2018

termina_build_image: create mount directories for lxd

Also copy in the about_os_credits.html for display by the host.

BUG= chromium:806119 
TEST=./termina_build_image

Change-Id: I7d77650c8da37edebf362c5bef00a8f9d553a696
Reviewed-on: https://chromium-review.googlesource.com/894284
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/8e3381b52a943d9da21c8534c0145714989a3186/termina_build_image

Status: Fixed (was: Started)
Components: OS>Systems>Containers

Sign in to add a comment