New issue
Advanced search Search tips

Issue 806109 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

net_unittests has been slow

Project Member Reported by zhongyi@chromium.org, Jan 26 2018

Issue description

Seemed like some QuicConnectionTests are slow. 

Suspect:
[4265/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/0 (321 ms)
[4266/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/1 (321 ms)
[4267/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/2 (305 ms)
[4268/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/3 (252 ms)
[4269/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/4 (343 ms)
[4270/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/5 (364 ms)
[4271/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/6 (329 ms)
[4272/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/7 (320 ms)
[4273/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/8 (264 ms)
[4274/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/9 (259 ms)
[4275/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/10 (267 ms)
[4276/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/11 (355 ms)
[4277/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/12 (323 ms)
[4278/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/13 (342 ms)
[4279/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/14 (322 ms)
[4280/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/15 (297 ms)
[4281/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/16 (260 ms)
[4282/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/17 (299 ms)
[4283/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/18 (369 ms)
[4284/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/19 (320 ms)
[4285/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/20 (302 ms)
[4286/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/21 (252 ms)
[4287/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/22 (251 ms)
[4288/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/23 (256 ms)
[4289/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/24 (278 ms)
[4290/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/25 (373 ms)
[4291/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/26 (320 ms)
[4292/4648] SupportedVersion/QuicConnectionTest.RejectUnencryptedStreamData/27 (319 ms)
[4461/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/0 (6839 ms)
[4462/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/1 (4990 ms)
[4463/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/2 (4903 ms)
[4464/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/3 (5120 ms)
[4465/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/4 (5466 ms)
[4466/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/5 (5076 ms)
[4467/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/6 (4923 ms)
[4468/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/7 (4935 ms)
[4469/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/8 (4915 ms)
[4470/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/9 (4961 ms)
[4471/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/10 (4967 ms)
[4472/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/11 (4935 ms)
[4473/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/12 (5171 ms)
[4474/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/13 (5531 ms)
[4475/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/14 (4919 ms)
[4476/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/15 (5212 ms)
[4477/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/16 (5088 ms)
[4478/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/17 (4972 ms)
[4479/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/18 (4916 ms)
[4480/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/19 (4975 ms)
[4481/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/20 (4756 ms)
[4482/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/21 (4680 ms)
[4483/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/22 (4728 ms)
[4484/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/23 (4738 ms)
[4485/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/24 (4667 ms)
[4486/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/25 (4672 ms)
[4487/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/26 (4633 ms)
[4488/4648] SupportedVersion/QuicConnectionTest.TooManySentPackets/27 (4635 ms)
[2117/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/0 (469 ms)
[2118/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/1 (467 ms)
[2119/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/2 (564 ms)
[2120/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/3 (500 ms)
[2121/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/4 (537 ms)
[2122/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/5 (464 ms)
[2123/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/6 (460 ms)
[2124/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/7 (455 ms)
[2125/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/8 (462 ms)
[2126/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/9 (464 ms)
[2127/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/10 (453 ms)
[2128/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/11 (457 ms)
[2129/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/12 (474 ms)
[2130/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/13 (453 ms)
[2131/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/14 (461 ms)
[2132/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/15 (760 ms)
[2133/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/16 (572 ms)
[2134/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/17 (479 ms)
[2135/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/18 (640 ms)
[2136/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/19 (601 ms)
[2137/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/20 (435 ms)
[2138/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/21 (548 ms)
[2139/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/22 (518 ms)
[2140/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/23 (512 ms)
[2141/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/24 (433 ms)
[2142/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/25 (508 ms)
[2143/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/26 (554 ms)
[2144/4648] SupportedVersion/QuicConnectionTest.SendingUnencryptedStreamDataFails/27 (552 ms)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e100126eadbdae92875a10f9bf157e9762b843a3

commit e100126eadbdae92875a10f9bf157e9762b843a3
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Wed Jan 31 00:15:59 2018

relnote: close connection on the sender side if there are too many
outstanding sent packets. This was accidentally removed for QUIC versions
greater than 33 when introducing new ack format.

Manually merge internal change: 183736634

Bug: 806109

Change-Id: I60a86ebda2dbb45646221c40b393b5f825c99fe2
Reviewed-on: https://chromium-review.googlesource.com/892206
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533105}
[modify] https://crrev.com/e100126eadbdae92875a10f9bf157e9762b843a3/net/quic/core/quic_connection.cc
[modify] https://crrev.com/e100126eadbdae92875a10f9bf157e9762b843a3/net/quic/core/quic_connection.h
[modify] https://crrev.com/e100126eadbdae92875a10f9bf157e9762b843a3/net/quic/core/quic_connection_test.cc
[modify] https://crrev.com/e100126eadbdae92875a10f9bf157e9762b843a3/net/quic/core/quic_flags_list.h
[modify] https://crrev.com/e100126eadbdae92875a10f9bf157e9762b843a3/net/quic/test_tools/quic_connection_peer.cc
[modify] https://crrev.com/e100126eadbdae92875a10f9bf157e9762b843a3/net/quic/test_tools/quic_connection_peer.h

Status: Fixed (was: Assigned)
After the patch landed, this test set runtime reduced from ~65s to 3s. Closing now.
Status: Available (was: Fixed)
MtuDiscovery related QuicConnection tests are relatively slow:

[21431/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/0 (133 ms)
[21432/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/1 (135 ms)
[21433/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/2 (152 ms)
[21434/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/3 (135 ms)
[21435/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/4 (132 ms)
[21436/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/5 (132 ms)
[21437/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/6 (131 ms)
[21438/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/7 (147 ms)
[21439/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/8 (133 ms)
[21440/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/9 (133 ms)
[21441/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/10 (148 ms)
[21442/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/11 (144 ms)
[21443/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/12 (159 ms)
[21444/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/13 (136 ms)
[21445/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/14 (131 ms)
[21446/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/15 (131 ms)
[21447/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/16 (132 ms)
[21448/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/17 (132 ms)
[21449/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/18 (131 ms)
[21450/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/19 (134 ms)
[21451/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/20 (132 ms)
[21452/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/21 (132 ms)
[21453/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/22 (132 ms)
[21454/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/23 (132 ms)
[21455/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/24 (132 ms)
[21456/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/25 (132 ms)
[21457/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/26 (131 ms)
[21458/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/27 (132 ms)
[21459/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/28 (132 ms)
[21460/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/29 (131 ms)
[21461/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/30 (132 ms)
[21462/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/31 (131 ms)
[21463/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/32 (131 ms)
[21464/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/33 (132 ms)
[21465/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/34 (131 ms)
[21466/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/35 (132 ms)
[21467/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/36 (131 ms)
[21468/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/37 (132 ms)
[21469/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/38 (131 ms)
[21470/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/39 (131 ms)
[21471/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/40 (131 ms)
[21472/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/41 (132 ms)
[21473/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/42 (131 ms)
[21474/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/43 (131 ms)
[21475/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/44 (131 ms)
[21476/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/45 (131 ms)
[21477/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/46 (131 ms)
[21478/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/47 (131 ms)
[21479/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/48 (131 ms)
[21480/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/49 (132 ms)
[21481/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/50 (131 ms)
[21482/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/51 (131 ms)
[21483/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/52 (131 ms)
[21484/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/53 (131 ms)
[21485/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/54 (131 ms)
[21486/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/55 (131 ms)
[21487/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/56 (132 ms)
[21488/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/57 (130 ms)
[21489/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/58 (131 ms)
[21490/21909] SupportedVersion/QuicConnectionTest.SendMtuDiscoveryPacket/59 (131 ms)

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63fe5d1154a02333af9b5817f69bdec4d579b28f

commit 63fe5d1154a02333af9b5817f69bdec4d579b28f
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Tue Jun 12 01:55:11 2018

Further lower the nubmer of probes between packets to make tests go much faster.

Also add a no-op WillOnce cause so that test eval goes faster.
Merge internal change: 199661222

Bug: 806109
Change-Id: Ib23ed18ae742188ef4a47579e11d2e528bfbbb03
Reviewed-on: https://chromium-review.googlesource.com/1091507
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566259}
[modify] https://crrev.com/63fe5d1154a02333af9b5817f69bdec4d579b28f/net/third_party/quic/core/quic_connection_test.cc

BbrSendTest/* and EndToEndTest/NegotiatedServerInitialFlowControlWindow are also slow.

Comment 6 by mmenke@chromium.org, Jun 13 2018

 Issue 851696  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b66ed289e297e8a7d0adee64a29728f8b58c1ad

commit 5b66ed289e297e8a7d0adee64a29728f8b58c1ad
Author: Ryan Hamilton <rch@chromium.org>
Date: Wed Jun 13 23:48:27 2018

Fix EXPECT_CALL for BufferedPacketStoreTest.*
Change-Id: I3dfc9477e6cd79358656119628ba660d36bf7e70

Bug: 806109
Change-Id: I3dfc9477e6cd79358656119628ba660d36bf7e70
Reviewed-on: https://chromium-review.googlesource.com/1098030
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567049}
[modify] https://crrev.com/5b66ed289e297e8a7d0adee64a29728f8b58c1ad/net/third_party/quic/core/quic_dispatcher_test.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95ea50c0784f16cd194b0696543cfab3a852c9f5

commit 95ea50c0784f16cd194b0696543cfab3a852c9f5
Author: Ryan Hamilton <rch@chromium.org>
Date: Fri Jun 15 21:01:09 2018

Remove support for the unused disable_hpack_dynamic_table connection option
Merge internal change: 200745921

Clean up the QUIC end-to-end-test GetTestParams loop and comments.
Merge internal change: 200748036

Only run the stateless reject versions of QUIC end-to-end tests for a single test. Currently the end-to-end tests are parameterized in such a way that we run 60 different versions of each of the 80 tests in end_to_end_tests.cc. This is a *ton* of tests and contributes to net_unittests in Chromium taking a very long time.

One of the dimensions that these tests are parameterized by is stateless reject support:
* supported by the client?
* supported by the server?
* using cheap stateless rejects?
But this only affects the *handshake* and does not affect subsequent operations. So there's really no need to run all 80 tests with all the combinations of stateless reject-ness. This CL changes things so that only a single test runs with all the various stateless reject configurations and cuts the end_to_end_test runtime in half.
Merge internal change: 200763662

Change-Id: I83ac58d0b8d34692d9db309cb45cfd7c6c64622b
Bug: 806109
Reviewed-on: https://chromium-review.googlesource.com/1102895
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567786}
[modify] https://crrev.com/95ea50c0784f16cd194b0696543cfab3a852c9f5/net/third_party/quic/core/crypto/crypto_protocol.h
[modify] https://crrev.com/95ea50c0784f16cd194b0696543cfab3a852c9f5/net/third_party/quic/core/end_to_end_test.cc
[modify] https://crrev.com/95ea50c0784f16cd194b0696543cfab3a852c9f5/net/third_party/quic/core/quic_spdy_session.cc
[modify] https://crrev.com/95ea50c0784f16cd194b0696543cfab3a852c9f5/net/third_party/quic/core/quic_spdy_session.h
[modify] https://crrev.com/95ea50c0784f16cd194b0696543cfab3a852c9f5/net/third_party/quic/core/quic_spdy_session_test.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7649cf7b60fbe29662936c88266841976670e88c

commit 7649cf7b60fbe29662936c88266841976670e88c
Author: Ryan Hamilton <rch@chromium.org>
Date: Sat Jun 16 01:23:40 2018

More QUIC test speedups.

* Only run one configuration of EXPECT_QUIC_BUG tests
* Shrink timeouts in EndToEndTest.PreSharedKey timeout tests

Speed up net_unitttests by 15%

Bug: 806109
Change-Id: If98cbfaf300b044f01f8a1d91ec96584e43aaef5
Reviewed-on: https://chromium-review.googlesource.com/1103393
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567851}
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/core/end_to_end_test.cc
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/core/quic_connection_test.cc
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/core/quic_packet_creator_test.cc
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/core/quic_server_session_base_test.cc
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/core/quic_session_test.cc
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/core/quic_spdy_session_test.cc
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/core/quic_spdy_stream_test.cc
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/tools/quic_simple_server_session_test.cc
[modify] https://crrev.com/7649cf7b60fbe29662936c88266841976670e88c/net/third_party/quic/tools/quic_simple_server_stream_test.cc

Some more tests are suspected to be slow(noticed when testing other changes locally): 
[18432/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/0 (311 ms)
[18433/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/1 (315 ms)
[18434/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/2 (318 ms)
[18435/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/3 (317 ms)
[18436/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/4 (318 ms)
[18437/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/5 (318 ms)
[18438/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/6 (318 ms)
[18439/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/7 (318 ms)
[18440/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/8 (318 ms)
[18441/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/9 (319 ms)
[18442/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/10 (318 ms)
[18443/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/11 (318 ms)
[18444/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/12 (318 ms)
[18445/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.HungAlternativeService/13 (318 ms)

[17844/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/0 (204 ms)
[17845/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/1 (176 ms)
[17846/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/2 (168 ms)
[17847/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/3 (166 ms)
[17848/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/4 (201 ms)
[17849/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/5 (190 ms)
[17850/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/6 (169 ms)
[17851/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/7 (169 ms)
[17852/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/8 (169 ms)
[17853/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/9 (171 ms)
[17854/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/10 (170 ms)
[17855/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/11 (180 ms)
[17856/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/12 (170 ms)
[17857/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.LargeResponseHeaders/13 (169 ms)
[17858/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/0 (166 ms)
[17859/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/1 (154 ms)
[17860/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/2 (132 ms)
[17861/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/3 (132 ms)
[17862/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/4 (132 ms)
[17863/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/5 (133 ms)
[17864/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/6 (131 ms)
[17865/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/7 (132 ms)
[17866/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/8 (131 ms)
[17867/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/9 (131 ms)
[17868/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/10 (132 ms)
[17869/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/11 (131 ms)
[17870/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/12 (132 ms)
[17871/18784] VersionIncludeStreamDependencySequence/QuicNetworkTransactionTest.TooLargeResponseHeaders/13 (132 ms)


Cc: zhongyi@chromium.org
Owner: ----
Unassign myself from the bug due to bandwidth this quarter. If anyone is interested to improve the net_unittests performance, feel free to take over the bug. 

Sign in to add a comment