New issue
Advanced search Search tips

Issue 806091 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Jan 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] Fix color contrast

Project Member Reported by yuweih@chromium.org, Jan 25 2018 
Found two more color contrast issues:
* Host setup instruction view's color ratio is only 3.4:1. Need to make the text darker.
* Settings menu's contrast ratio is only 2.6:1.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ab706d5308a0c054fcfb6b6486bd2eafd6c47f9

commit 8ab706d5308a0c054fcfb6b6486bd2eafd6c47f9
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Jan 26 20:44:29 2018

[CRD iOS] Increase contrast ratio

* Make text on host setup instruction view darker so that the contrast
  ratio is higher than 4.5:1.
* Use Google Blue palette for the settings menu. Make primary text bold.

Bug:  806091 
Change-Id: I7c6b02d502a24261e022eca329eb6766007563ea
Reviewed-on: https://chromium-review.googlesource.com/887720
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532058}
[modify] https://crrev.com/8ab706d5308a0c054fcfb6b6486bd2eafd6c47f9/remoting/ios/app/remoting_theme.mm
[modify] https://crrev.com/8ab706d5308a0c054fcfb6b6486bd2eafd6c47f9/remoting/ios/app/settings/remoting_settings_view_controller.mm

Comment 2 by yuweih@chromium.org, Jan 26 2018

Labels: Merge-Request-65
This CL fixes contrast ratio issues to pass a11y review.

This only affects Chrome Remote Desktop for iOS. It doesn't affect the Chrome browser.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 27 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 29 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05a707e6b8860f2975b1865b011a71631299cc7c

commit 05a707e6b8860f2975b1865b011a71631299cc7c
Author: Yuwei Huang <yuweih@chromium.org>
Date: Mon Jan 29 19:34:52 2018

[CRD iOS] Increase contrast ratio

* Make text on host setup instruction view darker so that the contrast
  ratio is higher than 4.5:1.
* Use Google Blue palette for the settings menu. Make primary text bold.

TBR=jamiewalch@chromium.org

Bug:  806091 
Change-Id: I7c6b02d502a24261e022eca329eb6766007563ea
Reviewed-on: https://chromium-review.googlesource.com/887720
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532058}(cherry picked from commit 8ab706d5308a0c054fcfb6b6486bd2eafd6c47f9)
Reviewed-on: https://chromium-review.googlesource.com/891641
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#149}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/05a707e6b8860f2975b1865b011a71631299cc7c/remoting/ios/app/remoting_theme.mm
[modify] https://crrev.com/05a707e6b8860f2975b1865b011a71631299cc7c/remoting/ios/app/settings/remoting_settings_view_controller.mm

Comment 5 by yuweih@chromium.org, Jan 30 2018

Status: Fixed (was: Assigned)

Comment 6 by ajnolley@chromium.org, Jul 18

Status: Verified (was: Fixed)
Verifed Fixed in 67.3396.22
►

Sign in to add a comment