typo in CSSRotateInterpolationType.cpp |
||
Issue descriptionhttps://codereview.chromium.org/2691863002/diff/40001/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp added if (m_inheritedRotation.isNone() || inheritedRotation.isNone()) return inheritedRotation.isNone() == inheritedRotation.isNone(); The lhs of == should start with m_. (This is now rewritten to the new foo_ style, but the bug is still there.) (Filing bug instead of sending CL because I don't know how to write a test.) Slightly related, you can concisely write multi-element comparisons using std::tie (https://cs.chromium.org/search/?q=std::tie&sq=package:chromium&type=cs) (though it's more useful for < than ==)
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/803a72fbbd1de809be962eb7c8ec81f02924c690 commit 803a72fbbd1de809be962eb7c8ec81f02924c690 Author: Eric Willigers <ericwilligers@chromium.org> Date: Mon Jan 29 02:28:46 2018 CSS Animation: CSSRotateInterpolationType typo fix LHS and RHS of comparison were identical, when we should have been comparing the current parent rotation with the stored parent rotation. Added a responsive animation test where the inherited rotation changes from none. BUG= 806085 Change-Id: I9fc85ff2b7ddd894bd07d03eed90f8c23f26f6e4 Reviewed-on: https://chromium-review.googlesource.com/890682 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#532305} [add] https://crrev.com/803a72fbbd1de809be962eb7c8ec81f02924c690/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-rotate.html [modify] https://crrev.com/803a72fbbd1de809be962eb7c8ec81f02924c690/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
,
Jan 29 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ericwilligers@chromium.org
, Jan 26 2018