New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806056 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 805543



Sign in to add a comment

Update endpoints (v2) dependencies in luci-py

Project Member Reported by mar...@chromium.org, Jan 25 2018

Issue description

In luci-py.git //appengine/third_party, running:

  pip install -t . google-endpoints --ignore-installed --no-compile
  rm -rf *-info

installs oauth2client v3.0.0 (!) and many other libraries, 47 in total. We should backport the one that makes sense back into //client/third_party and leave the rest then, but it is known that oauth2client is not trivial to upgrade.

This bug is about tracking upgrading all third party dependencies one at a time, until endpoints can be installed. This is orthogonal to issue 805076 which doesn't depend on this.
 

Comment 1 by mar...@chromium.org, Jan 26 2018

Owner: mar...@chromium.org
Status: Assigned (was: Untriaged)
I'll try to attack oauth2client first.

Comment 2 by s...@google.com, Apr 19 2018

Cc: smut@chromium.org
Do we have to upgrade oauth2client? We could keep the existing version in client/third_party and the version required by Endpoints v2 in appengine/third_party. Arguably, then, upgrading client/third_party's copy of oauth2client is orthogonal, no need to block Endpoints v2 migration on it.

Comment 3 by mar...@chromium.org, Apr 19 2018

Maybe, I guess we can accumulate some technical debt to not block the ditching of v1 on this but I wasn't warm to this idea.
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c29dd88982a25825906f47f092be62f43cf51cdd

commit c29dd88982a25825906f47f092be62f43cf51cdd
Author: smut <smut@google.com>
Date: Thu May 10 23:48:07 2018

Update ts_mon for oauth2client 3.0.0 compatibility

Similar to how oauth2client/gce.py moved to oauth2client/contrib/gce.py,
oauth2client/appengine.py also moved to oauth2client/contrib/appengine.py.

Bug: 806056
Change-Id: I6abb85cda2457541f86e202a6b5323afa3d7894c
Reviewed-on: https://chromium-review.googlesource.com/1019363
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/c29dd88982a25825906f47f092be62f43cf51cdd/packages/infra_libs/infra_libs/ts_mon/common/monitors.py

Sign in to add a comment