New issue
Advanced search Search tips

Issue 806031 link

Starred by 1 user
Status: Fixed
Owner:
bokan@chromium.org
Closed: Sep 6
Cc:
szager@chromium.org
skobes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 823365



Sign in to add a comment

[root layer scrolls] LayoutObject::AbsoluteVisualRect is misnamed

Project Member Reported by bokan@chromium.org, Jan 25 2018 
This method uses MapVisualRectInAncestorSpace() with LayoutView as the ancestor. However, comments on that say "Overflow clipping, CSS clipping and scrolling is *not* applied for |ancestor| itself if |ancestor| scrolls overflow.". This means AbsoluteVisualRect isn't actually returning absolute coordinates, but content/document coordinates. It's correct when RLS is off because absolute==content but when it's turned on absolute means frame coordinates.

This bug is to track auditing call sites, fixing the method name and comments.

Comment 1 by bokan@chromium.org, Jan 25 2018

Blocking: 417782

Comment 2 by skobes@chromium.org, Jan 30 2018

Blocking: -417782
We should clean this up, but I don't think it should block launching RLS.

Comment 3 by bokan@chromium.org, Apr 17 2018

Blocking: 823365
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda

commit e9f51e1afe36de7be3affa78fbbf2ecb948b1bda
Author: Steve Kobes <skobes@chromium.org>
Date: Tue Sep 04 17:44:29 2018

Rename LayoutObject::AbsoluteVisualRect.

We've settled on "frame" and "document" coordintes, and no longer talk
about "absolute".

Bug:  806031 
Change-Id: I38da759ffe9554783a36a2818708969b5089d33e
Reviewed-on: https://chromium-review.googlesource.com/1204411
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588579}
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/layout_inline.cc
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/layout_inline.h
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_block.cc
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_block.h
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_hidden_container.h
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_inline.cc
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_inline.h
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_inline_text.cc
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_inline_text.h
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_model_object.cc
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/layout/svg/layout_svg_model_object.h
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/core/page/spatial_navigation.cc
[modify] https://crrev.com/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc

Comment 5 by skobes@chromium.org, Sep 6

Status: Fixed (was: Assigned)
►

Sign in to add a comment