New issue
Advanced search Search tips

Issue 806028 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Crash in location_bar_coordinator::updateOmniboxState

Project Member Reported by justincohen@chromium.org, Jan 25 2018

Issue description

_locationBarController is nil on startup.


- (void)updateOmniboxState {
  _locationBarController->SetShouldShowHintText(
      [self.delegate toolbarModelIOS]->ShouldDisplayHintText());
  _locationBarController->OnToolbarUpdated();
}


#0  0x0000000102e4ca58 in ::-[LocationBarCoordinator updateOmniboxState]() at ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm:107
#1  0x0000000102e4f1ac in ::-[LocationBarMediator updateConsumer]() at ios/chrome/browser/ui/location_bar/location_bar_mediator.mm:158
#2  0x0000000102e4efd0 in ::-[LocationBarMediator setConsumer:](id) at ios/chrome/browser/ui/location_bar/location_bar_mediator.mm:141
#3  0x0000000102e4c7e0 in ::-[LocationBarCoordinator start]() at ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm:95
#4  0x0000000102e57554 in ::-[ToolbarCoordinator start]() at ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm:133
#5  0x0000000102be4090 in ::-[ToolbarAdapter start]() at ios/chrome/browser/ui/toolbar/toolbar_adapter.mm:130
#6  0x0000000102bdf69c in ::-[LegacyToolbarCoordinator setToolbarController:](id) at ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.mm:118
#7  0x00000001032cd224 in ::-[BrowserViewController buildToolbarAndTabStrip]() at ios/chrome/browser/ui/browser_view_controller.mm:1972
#8  0x00000001032c9174 in ::-[BrowserViewController viewDidLoad]() at ios/chrome/browser/ui/browser_view_controller.mm:1593
#9  0x000000018e7e5a00 in -[UIViewController loadViewIfRequired] ()
#10 0x000000018e7e55d8 in -[UIViewController view] ()
#11 0x00000001035d773c in ::-[BVCContainerViewController setCurrentBVC:](UIViewController *) at ios/chrome/browser/ui/main/main_presenting_view_controller.mm:46
#12 0x00000001035d9b70 in ::-[MainPresentingViewController showTabViewController:completion:](UIViewController *, ProceduralBlock) at ios/chrome/browser/ui/main/main_presenting_view_controller.mm:196
#13 0x000000010211d24c in ::-[MainController displayCurrentBVC]() at ios/chrome/app/main_controller.mm:1812
#14 0x000000010211c898 in ::-[MainController setCurrentBVC:](BrowserViewController *) at ios/chrome/app/main_controller.mm:1737
#15 0x0000000102116548 in ::-[MainController createInitialUI:](ApplicationMode) at ios/chrome/app/main_controller.mm:1229
#16 0x0000000102112168 in ::-[MainController startUpBrowserForegroundInitialization]() at ios/chrome/app/main_controller.mm:744
#17 0x0000000102110cd4 in ::-[MainController startUpBrowserToStage:](BrowserInitializationStageType) at ios/chrome/app/main_controller.mm:588
#18 0x0000000102b077cc in ::-[AppState initializeUI]() at ios/chrome/app/application_delegate/app_state.mm:494
#19 0x0000000102b07064 in ::-[AppState requiresHandlingAfterLaunchWithOptions:stateBackground:](NSDictionary *, BOOL) at ios/chrome/app/application_delegate/app_state.mm:447
#20 0x000000010210f3f8 in ::-[MainApplicationDelegate application:didFinishLaunchingWithOptions:](UIApplication *, NSDictionary *) at ios/chrome/app/main_application_delegate.mm:101

 
Labels: ReleaseBlock-Stable M-66
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/883504 will solve it, we just need to make sure the locationBarController is created before the mediator.

Comment 2 by gov...@chromium.org, Jan 26 2018

Pls apply appropriate OSs label. Thank you.
Labels: OS-iOS
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b7d447cc7b0f5ee0a61928f89291ba837f581d6

commit 0b7d447cc7b0f5ee0a61928f89291ba837f581d6
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Jan 29 18:08:41 2018

Move LocationBarControllerImpl and PopupCoordinator to LocationBar

Moves the _locationBar ivar (it becomes _locationBarController) to
LocationBarCoordinator. Moves popup coordinator, too.

Bug:  785253 ,  806028 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4bea5a069fc2caeb76f27d204eeddd8d5b281430
Reviewed-on: https://chromium-review.googlesource.com/883504
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532489}
[modify] https://crrev.com/0b7d447cc7b0f5ee0a61928f89291ba837f581d6/ios/chrome/browser/ui/location_bar/BUILD.gn
[modify] https://crrev.com/0b7d447cc7b0f5ee0a61928f89291ba837f581d6/ios/chrome/browser/ui/location_bar/location_bar_coordinator.h
[modify] https://crrev.com/0b7d447cc7b0f5ee0a61928f89291ba837f581d6/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
[modify] https://crrev.com/0b7d447cc7b0f5ee0a61928f89291ba837f581d6/ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm
[modify] https://crrev.com/0b7d447cc7b0f5ee0a61928f89291ba837f581d6/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/0b7d447cc7b0f5ee0a61928f89291ba837f581d6/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/0b7d447cc7b0f5ee0a61928f89291ba837f581d6/ios/chrome/browser/ui/toolbar/clean/BUILD.gn
[modify] https://crrev.com/0b7d447cc7b0f5ee0a61928f89291ba837f581d6/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm

Issue 806336 has been merged into this issue.
Cc: linds...@chromium.org
Labels: -ReleaseBlock-Stable ReleaseBlock-Dev
Moving RBD label from duped bug over here.  Looks like a CL has landed, but I'm not sure if that's the complete fix; I'll let stk update the status accordingly.

Comment 8 by pkl@chromium.org, Jan 29 2018

Components: UI>Browser>Toolbar
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on 66.0.3335.0 Canary. App is not crashing on clean install and on upgrade.

Sign in to add a comment