New issue
Advanced search Search tips

Issue 806005 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

CreateAnswer WebRTC Web Platform Tests failing with pending change in WebRTC

Project Member Reported by steveanton@chromium.org, Jan 25 2018

Issue description

With this WebRTC change (https://webrtc-review.googlesource.com/c/src/+/41042), the following Web Platform Tests will start failing:

external/wpt/webrtc/RTCPeerConnection-createAnswer.html

This is because of a change to a CreateAnswer error message.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/359e47b2bc84b6344f0d386de6a12789f78e1696

commit 359e47b2bc84b6344f0d386de6a12789f78e1696
Author: Steve Anton <steveanton@chromium.org>
Date: Fri Jan 26 19:42:11 2018

Allow PeerConnection-createAnswer WPTs to fail

https://webrtc-review.googlesource.com/c/src/+/41042 will change
an error message in CreateAnswer which would break this WPT. Once
the WebRTC CL has rolled in the test expectation will be updated
and the test re-enabled.

Bug:  806005 
Change-Id: I53855be0dcc23bb76a6a6087761198beb82262dc
Reviewed-on: https://chromium-review.googlesource.com/887371
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532041}
[modify] https://crrev.com/359e47b2bc84b6344f0d386de6a12789f78e1696/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89c398bf45e4c66b3a6006c1c99b904a22d31db1

commit 89c398bf45e4c66b3a6006c1c99b904a22d31db1
Author: Steve Anton <steveanton@chromium.org>
Date: Thu Feb 08 05:09:20 2018

Re-enable PeerConnection WPTs that were failing after the WebRTC roll

Bug:  806005 
Change-Id: I8892ce56fa9471c20505685f79643cd6d5f918c8
Reviewed-on: https://chromium-review.googlesource.com/887441
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535307}
[modify] https://crrev.com/89c398bf45e4c66b3a6006c1c99b904a22d31db1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/89c398bf45e4c66b3a6006c1c99b904a22d31db1/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createAnswer-expected.txt

Status: Fixed (was: Started)

Sign in to add a comment