New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806004 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

[VR] Clank omnibox occasionally drawn to VR content texture.

Project Member Reported by asimjour@chromium.org, Jan 25 2018

Issue description

Sometimes the omnibox shows up in VR. All the events will have an offset after this and the browser is not usable.

 
Screenshot_20180124-155732.png
1.1 MB View Download
Labels: M66
Status: Available (was: Untriaged)
Summary: [VR] Clank omnibox occasionally drawn to VR content texture. (was: [VR] Hide clank Omnibox when in VR)
Note that this is not the same as  issue 807647 . Fixing  issue 807647  will cause us to indefinitely see a black content quad when we run into this issue, which is probably less bad than showing broken content.

Under some circumstances unknown to me, the render-drawn omnibox just never hides itself.
I can't get a reliable repro, but this only seems to happen when navigating while entering VR...
Labels: -M66 M-66
FTR, I saw the indefinite black content quad yesterday afternoon with either a ToT build or latest Canary.

Comment 7 by ericde@google.com, Mar 3 2018

Labels: Hotlist-VRB-MVP
Cc: -mthiesse@chromium.org
Owner: mthiesse@chromium.org
We basically have a 100% repro of this issue when cold-launching Chrome from DDH. This *needs* to be fixed at least for 67, but preferably for 66.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da202f037c3a313b6be1a85c9e2789a2d8df8b40

commit da202f037c3a313b6be1a85c9e2789a2d8df8b40
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Mar 14 18:53:28 2018

VR: Don't use stay_hidden animation on O+

We don't need to use the stay_hidden animation to hide the preview
window on O+ because we use the vrmode configuration to disable the
preview window when launching the Activity in VR.

This also sped up VR entry significantly enough to expose a race
condition where if you hide the controls before the render has had time
to produce a frame, the java and native code disagree on the state of
the controls, but the native code defaults to thinking the previous
state is controls hidden, and so drops the message.

Bug: 817934,  806004 
Change-Id: I6f4caaaf29c1fede7f21376d21d5ab86c5010523
Reviewed-on: https://chromium-review.googlesource.com/961265
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543143}
[modify] https://crrev.com/da202f037c3a313b6be1a85c9e2789a2d8df8b40/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrIntentUtils.java
[modify] https://crrev.com/da202f037c3a313b6be1a85c9e2789a2d8df8b40/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/da202f037c3a313b6be1a85c9e2789a2d8df8b40/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/da202f037c3a313b6be1a85c9e2789a2d8df8b40/content/browser/renderer_host/render_widget_host_view_android.h

Labels: Test-Complete
Status: Fixed (was: Available)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 19 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebf322e2aac011b298ea339bf3957dec99b7ffb2

commit ebf322e2aac011b298ea339bf3957dec99b7ffb2
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Mon Mar 19 17:32:29 2018

VR: Don't use stay_hidden animation on O+

We don't need to use the stay_hidden animation to hide the preview
window on O+ because we use the vrmode configuration to disable the
preview window when launching the Activity in VR.

This also sped up VR entry significantly enough to expose a race
condition where if you hide the controls before the render has had time
to produce a frame, the java and native code disagree on the state of
the controls, but the native code defaults to thinking the previous
state is controls hidden, and so drops the message.

TBR=mthiesse@chromium.org

(cherry picked from commit da202f037c3a313b6be1a85c9e2789a2d8df8b40)

Bug: 817934,  806004 
Change-Id: I6f4caaaf29c1fede7f21376d21d5ab86c5010523
Reviewed-on: https://chromium-review.googlesource.com/961265
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#543143}
Reviewed-on: https://chromium-review.googlesource.com/969090
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#310}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/ebf322e2aac011b298ea339bf3957dec99b7ffb2/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrIntentUtils.java
[modify] https://crrev.com/ebf322e2aac011b298ea339bf3957dec99b7ffb2/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/ebf322e2aac011b298ea339bf3957dec99b7ffb2/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/ebf322e2aac011b298ea339bf3957dec99b7ffb2/content/browser/renderer_host/render_widget_host_view_android.h

Sign in to add a comment