Issue metadata
Sign in to add a comment
|
1.8%-3.6% regression in blink_perf.owp_storage at 530193:530399 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 25 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14bf63e2840000
,
Jan 26 2018
๐ Found a significant difference after 1 commit. https://pinpoint.chromeperf.appspot.com/job/14bf63e2840000 Eliminate blink::BlobDataItem. By mek@chromium.org ยท Thu Jan 18 21:42:40 2018 chromium @ db1b4e28db01ef1f2fa9f138a426165f636f07cc Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 29 2018
Not sure why this would be causing a regression, but I think the difference is small enough not to worry about.
,
Jan 29 2018
I don't understand this metric so I cannot judge the significance of this regression. I will leave it up to the benchmark owner (dmurph@) to re-open if they disagree.
,
Jan 29 2018
I tried to look into this a bit deeper since the new code should be faster/do less allocations, and did some profiling. Hard to get any meaningful data though since these tests really are doing so little work (creating blobs of 2 bytes) that any difference is dwarfed by the fixed overhead of creating/reading blobs. So not sure why these tests seem to in fact have gotten consistently slower after my change, but I'm fairly confident it's nothing to worry about (and all the mojo blob changes together still made these tests way faster than they ever were, but that's mostly on the loading side, not the creation side). |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 25 2018