Issue metadata
Sign in to add a comment
|
5.9% regression in rasterize_and_record_micro.top_25 at 531353:531398 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 25 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/128964dc840000
,
Jan 26 2018
📍 Couldn't reproduce a difference. https://pinpoint.chromeperf.appspot.com/job/128964dc840000
,
Feb 5 2018
,
Mar 4 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14e91e3c440000
,
Mar 4 2018
Last bisect actually hit a swarming timeout. Trying again on a wider range.
,
Mar 16 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17e205be440000
,
Mar 16 2018
Trying another bisect.
,
Mar 16 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/17e205be440000 Use the actual Chrome OS AFDO profiles on Android by gbiv@chromium.org https://chromium.googlesource.com/chromium/src/+/1f751e41506c1b1c875ca589681872f725b6d7ab Move video_capture.mojom out of content. by xjz@chromium.org https://chromium.googlesource.com/chromium/src/+/a4b93b7a062e8b03bdb1c0a605fe5dabc2bc50b0 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 16 2018
My refactoring change is purely namespace change, which sounds unlikely related to this regression. gbiv@: Can you PTAL at the other change?
,
Mar 16 2018
Looking at the longer-term graph, I see a substantial perf improvement when 2e17642e132375121818223a87d8eb02efbf4004, which was supposed to fix perf regressions like this, landed. Kicked off a pinpoint job in issue 822868 to verify that 2e17642e132375121818223a87d8eb02efbf4004 gets credit for that perf improvement. If so, we should be good here. :)
,
Mar 19 2018
So, the pinpoint bots apparently don't like me. :) Since we saw such a pronounced improvement (and correction from a new profile shortly after), I'm going to go with my original plan of assuming that the improvement was caused by 2e17642e132375121818223a87d8eb02efbf4004. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 25 2018