New issue
Advanced search Search tips

Issue 805921 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 803553



Sign in to add a comment

[Mac] Reload icon in toolbar should not mirror in RTL

Project Member Reported by lgrey@chromium.org, Jan 25 2018

Issue description

Blocking: 803553
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f8dbc8d1358729387a3a331382d5956d3af68c9

commit 3f8dbc8d1358729387a3a331382d5956d3af68c9
Author: Leonard Grey <lgrey@chromium.org>
Date: Fri Jan 26 18:04:11 2018

[MacRTL] Don't mirror reload toolbar icon

This came up in UX review. From Material Guidelines:
"Clocks still turn clockwise for RTL languages. A clock icon or a circular
refresh or progress indicator with an arrow pointing clockwise should not
be mirrored."

Bug:  805921 
Change-Id: I1d345727b8656964b0574af9ccdc7d5dc26f8661
Reviewed-on: https://chromium-review.googlesource.com/887301
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532009}
[modify] https://crrev.com/3f8dbc8d1358729387a3a331382d5956d3af68c9/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
[modify] https://crrev.com/3f8dbc8d1358729387a3a331382d5956d3af68c9/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h
[modify] https://crrev.com/3f8dbc8d1358729387a3a331382d5956d3af68c9/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm

Comment 3 by lgrey@chromium.org, Jan 29 2018

Labels: Merge-Request-65
Status: Fixed (was: Assigned)
Requesting merge to 65 since this is a UX blocker for Mac RTL launch (Issue 803553) and is extremely low-risk.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 30 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6a85776ca0a9a72828c2cd45e19e5a7bf59f9c8

commit a6a85776ca0a9a72828c2cd45e19e5a7bf59f9c8
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Jan 30 18:48:41 2018

[MacRTL] Don't mirror reload toolbar icon

This came up in UX review. From Material Guidelines:
"Clocks still turn clockwise for RTL languages. A clock icon or a circular
refresh or progress indicator with an arrow pointing clockwise should not
be mirrored."

Bug:  805921 
Change-Id: I1d345727b8656964b0574af9ccdc7d5dc26f8661
Reviewed-on: https://chromium-review.googlesource.com/887301
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532009}(cherry picked from commit 3f8dbc8d1358729387a3a331382d5956d3af68c9)
Reviewed-on: https://chromium-review.googlesource.com/893922
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#177}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/a6a85776ca0a9a72828c2cd45e19e5a7bf59f9c8/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
[modify] https://crrev.com/a6a85776ca0a9a72828c2cd45e19e5a7bf59f9c8/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h
[modify] https://crrev.com/a6a85776ca0a9a72828c2cd45e19e5a7bf59f9c8/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm

Labels: TE-Verified-M65 TE-Verified-65.0.3325.51
Verified the fix on Mac 10.12.6 using Chrome dev version #65.0.3325.51 as per the comment #0 and #2.
Attaching screen shot for reference.
Observed that reload icon in toolbar did not mirror in RTL.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
805921.png
485 KB View Download

Sign in to add a comment