Media Engagement visits increase when no "real" navigation |
|||||||
Issue descriptionChrome Version : 66.0.3329.0 OS Version: 10335.0.0 What steps will reproduce the problem? 1. Open about:media-engagement and check youtube.com visits 2. Open youtube.com tab and closed it 3. Check youtube.com visits increased by one 4. Open a new tab and press "y" to highlight youtube.com 5. Check youtube.com visits What is the expected result? They should be the same. What happens instead of that? They increased by one. I can reproduce 100%.
,
Feb 1 2018
This is confirmed to be the prerender kicking in. I have a CL fixing it. Should be uploaded soon.
,
Feb 1 2018
I think we should attempt to merge this in M65 given the impact it may likely have on MEI numbers.
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5088a06385ccd2028000065f4011059deaf801b4 commit 5088a06385ccd2028000065f4011059deaf801b4 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Mon Feb 05 14:19:05 2018 Media Engagement: ignore prerender/preload navigations. Prerender/preload navigations are not tagged as such in the NavigationHandle, requiring us to explicitly check with the PrerenderManager if we are running in such a context. This should solve a cause for many fake visits. Bug: 805918 Change-Id: I9b397822465086dcb97ca72e3e4d1df324cf324e Reviewed-on: https://chromium-review.googlesource.com/897500 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#534379} [modify] https://crrev.com/5088a06385ccd2028000065f4011059deaf801b4/chrome/browser/media/media_engagement_browsertest.cc [modify] https://crrev.com/5088a06385ccd2028000065f4011059deaf801b4/chrome/browser/media/media_engagement_service.cc
,
Feb 5 2018
,
Feb 5 2018
Please verify the fix in canary.
,
Feb 6 2018
Verified in Chrome 66.0.3341.0 (Official Build) canary (64-bit)
,
Feb 6 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3951bd55dc20db757b4121c1d37f4ac39da4e814 commit 3951bd55dc20db757b4121c1d37f4ac39da4e814 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Feb 06 14:51:56 2018 Media Engagement: ignore prerender/preload navigations. Prerender/preload navigations are not tagged as such in the NavigationHandle, requiring us to explicitly check with the PrerenderManager if we are running in such a context. This should solve a cause for many fake visits. Bug: 805918 Change-Id: I9b397822465086dcb97ca72e3e4d1df324cf324e Reviewed-on: https://chromium-review.googlesource.com/897500 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534379}(cherry picked from commit 5088a06385ccd2028000065f4011059deaf801b4) Reviewed-on: https://chromium-review.googlesource.com/904166 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#345} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/3951bd55dc20db757b4121c1d37f4ac39da4e814/chrome/browser/media/media_engagement_browsertest.cc [modify] https://crrev.com/3951bd55dc20db757b4121c1d37f4ac39da4e814/chrome/browser/media/media_engagement_service.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yini...@chromium.org
, Jan 31 2018