New issue
Advanced search Search tips

Issue 805916 link

Starred by 1 user
Status: Fixed
Owner:
sa...@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

chrome/browser:browser has underspecified dependencies for chrome / browser / printing / cloud_print / cloud_print_proxy_service.h

Project Member Reported by thakis@chromium.org, Jan 25 2018 
Locally:

ninja -C out/gn  -j200 ../../chrome/browser/ui/cocoa/translate/translate_bubble_controller_unittest.mm^
...
../../chrome/browser/printing/cloud_print/cloud_print_proxy_service.h:16:10: fatal error: 'chrome/common/cloud_print.mojom.h' file not found


That include was added in https://chromium.googlesource.com/chromium/src/+/b1f63d6078e454eb0d7773db55352a05020f1eaa ; looks like that forgot to add a dep on the target generating the header.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9015c1ff17c116901042e56b9905f77d1f86183e

commit 9015c1ff17c116901042e56b9905f77d1f86183e
Author: Sam McNally <sammc@chromium.org>
Date: Mon Jan 29 18:55:59 2018

Add missing deps on //chrome/common:service_process_mojom.

//chrome/browser correctly lists //chrome/common:service_process_mojom
in its public_deps. However, //chrome/browser/extensions and
//chrome/browser/ui are listed in allow_circular_includes_from, allowing
them to include headers from //chrome/browser without a dependency. Add
explicit dependencies from //chrome/browser/extensions and
//chrome/browser/ui to //chrome/common:service_process_mojom.

Bug:  805916 
Change-Id: I83c2c7588e8056d413b9cccc8f5eceeb203986d7
Reviewed-on: https://chromium-review.googlesource.com/890686
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532517}
[modify] https://crrev.com/9015c1ff17c116901042e56b9905f77d1f86183e/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/9015c1ff17c116901042e56b9905f77d1f86183e/chrome/browser/ui/BUILD.gn

Comment 2 by sa...@chromium.org, Jan 30 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment