New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805906 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Build Output: Reduce verbosity of debug build

Project Member Reported by wnwen@chromium.org, Jan 25 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fc13c1a11a16b219aec364293316ba4df17bfee

commit 4fc13c1a11a16b219aec364293316ba4df17bfee
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Jan 29 20:37:24 2018

Android: Stop enforcing deprecation and unchecked

No longer enforce full deprecation and unchecked warnings by commandline
flags to javac. Greatly reduce verbosity of build output.

BUG= 805906 

Change-Id: I20ac2f56d9bfa5ed946789373eae536089e7506e
Reviewed-on: https://chromium-review.googlesource.com/887001
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532573}
[modify] https://crrev.com/4fc13c1a11a16b219aec364293316ba4df17bfee/build/android/gyp/javac.py
[modify] https://crrev.com/4fc13c1a11a16b219aec364293316ba4df17bfee/third_party/opus/convert_rtcd_assembler.py

Comment 2 by wnwen@chromium.org, Jan 29 2018

Opps, actually that CL only stops enforcing deprecation and filters it and coalesced unchecked (usually for non-chromium targets) and coalesced deprecated warnings out of the build output.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d95267aeb690f11a153fb8083f86505ce6e2c31

commit 5d95267aeb690f11a153fb8083f86505ce6e2c31
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jan 31 20:22:25 2018

Android: Fix unchecked lint warnings

TBR=nyquist@chromium.org,yzshen@chromium.org,piman@chromium.org

Bug:  805906 
Change-Id: I593115daa9d8b0884f552e3781eeaeeec154bb43
Reviewed-on: https://chromium-review.googlesource.com/895923
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533381}
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/base/test/android/junit/src/org/chromium/base/test/util/AnnotationProcessingUtilsTest.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/chrome/android/java/src/org/chromium/chrome/browser/compositor/animation/CompositorAnimator.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/prefetch/OfflineNotificationBackgroundTaskUnitTest.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderUnitTest.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/ImageFetcherTest.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManager.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/content/public/android/junit/src/org/chromium/content/browser/remoteobjects/RemoteObjectImplTest.java
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/5d95267aeb690f11a153fb8083f86505ce6e2c31/testing/android/junit/java/src/org/chromium/testing/local/CustomShadowAsyncTask.java

Comment 4 by wnwen@chromium.org, Jan 31 2018

Status: Fixed (was: Assigned)
With this latest change, building "ngn all":

cleangn && ngn all                                                                                                             
ninja: Entering directory `out/Debug'                                                                                                                                            
[1/1] Regenerating ninja files                                                                                                     
[6461/75352] ACTION //base/android/jni_generator:jni_generator_py_tests(//build/toolchain/android:android_clang_arm)                                                            
..........................                                                                                                      
----------------------------------------------------------------------                                                                             
Ran 26 tests in 0.315s                                                                                                       
                                                                                                                               
OK                                                                                                                              
[75352/75352] STAMP obj/clank/official_tests.stamp

I will call this a success and close the bug, here are the gn args:
use_goma = true
target_os = "android"
is_debug = true
is_clang = true
symbol_level = 1
disable_incremental_isolated_processes=true
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52efd31928fd190418dc64ca0eb9018bf502c4e9

commit 52efd31928fd190418dc64ca0eb9018bf502c4e9
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jan 31 22:04:52 2018

Android: Remove jni_generator test from build

This test should either be run by presubmit or a trybot or manually.

Bug:  805906 
Change-Id: I12cce1179fecc9ea40ff3781acb14962a1fd80a0
Reviewed-on: https://chromium-review.googlesource.com/895397
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533431}
[modify] https://crrev.com/52efd31928fd190418dc64ca0eb9018bf502c4e9/base/android/jni_generator/BUILD.gn
[add] https://crrev.com/52efd31928fd190418dc64ca0eb9018bf502c4e9/base/android/jni_generator/PRESUBMIT.py
[modify] https://crrev.com/52efd31928fd190418dc64ca0eb9018bf502c4e9/base/android/jni_generator/jni_generator_tests.py

Comment 6 by wnwen@chromium.org, Jan 31 2018

Now a debug build should have no more output. :)

Comment 7 by wnwen@chromium.org, May 17 2018

Summary: Build Output: Reduce verbosity of debug build (was: Reduce verbosity of builds)

Sign in to add a comment