New issue
Advanced search Search tips

Issue 805894 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

[clang] Code bloat when making some widely used methods constexpr

Project Member Reported by gab@chromium.org, Jan 25 2018

Issue description

trunk@r531862:
	43,278,848 chrome.dll
	63,684,608 chrome_child.dll

trunk@r531862 + https://chromium-review.googlesource.com/c/chromium/src/+/883126:
	43,294,720 chrome.dll
	63,702,528 chrome_child.dll

Diff + ~16-18KB per DLL.



GN Args (on Win10 x64):
  target_cpu = "x86"
  is_official_build = true
  is_chrome_branded = false

  use_goma = true
  goma_dir = "C:\src\goma\goma-win64"
 

Comment 1 by thakis@chromium.org, Jan 25 2018

Blocking: 82385
Cc: h...@chromium.org brucedaw...@chromium.org
Interesting.

I wonder if https://www.chromium.org/developers/windows-binary-sizes would tell us anything interesting.

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Comment 5 by gab@chromium.org, Jan 25 2018

Actually, the full diff is caused by https://chromium-review.googlesource.com/886708 (stripped down).

So it might have to do with the inlining (required by constexpr) more than constexpr per se.

Comment 6 by h...@chromium.org, Jan 25 2018

Ah, that makes sense. I wouldn't expect constexpr itself to affect this.

Comment 7 by thakis@chromium.org, Jan 25 2018

Status: WontFix (was: Untriaged)
Ok, sounds like this is understood then, and then compiler is doing alright.

Sign in to add a comment