PVS-Studio again
Reported by
karpov2...@gmail.com,
Jan 25 2018
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Steps to reproduce the problem: Article: Chromium: About the Sixth Check of the Project - https://www.viva64.com/en/b/0552/ Bugs: http://cppfiles.com/chromium.txt What is the expected behavior? What went wrong? PVS-Studio is not used :). Did this work before? No Chrome version: 65 Channel: n/a OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Jan 25 2018
,
Jan 26 2018
The following revision refers to this bug: https://swiftshader.googlesource.com/SwiftShader.git/+/6c4564af39aeb8eef2fe6dc6cb73cb9f2dd9b891 commit 6c4564af39aeb8eef2fe6dc6cb73cb9f2dd9b891 Author: Nicolas Capens <capn@google.com> Date: Fri Jan 26 13:34:18 2018 Add missing break in switch. Also replace some extension enums with core ones. Bug chromium:805881 Change-Id: I80a9b658fb8dda9c759c4d79b89fbe71b8b91ae1 Reviewed-on: https://swiftshader-review.googlesource.com/16728 Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> [modify] https://crrev.com/6c4564af39aeb8eef2fe6dc6cb73cb9f2dd9b891/src/OpenGL/libGLESv2/Context.cpp [modify] https://crrev.com/6c4564af39aeb8eef2fe6dc6cb73cb9f2dd9b891/src/OpenGL/libGLESv2/libGLESv2.cpp [modify] https://crrev.com/6c4564af39aeb8eef2fe6dc6cb73cb9f2dd9b891/src/OpenGL/libGLESv2/libGLESv3.cpp
,
Jan 26 2018
The following revision refers to this bug: https://swiftshader.googlesource.com/SwiftShader.git/+/9b5aa7095224a59ceb3f3db46b3f9767111a6850 commit 9b5aa7095224a59ceb3f3db46b3f9767111a6850 Author: Nicolas Capens <capn@google.com> Date: Fri Jan 26 13:34:18 2018 Fix checking each cube face for changes. Bug chromium:805881 Change-Id: I4b63d6415e87f32cc1402649486b2e4d821db546 Reviewed-on: https://swiftshader-review.googlesource.com/16729 Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> [modify] https://crrev.com/9b5aa7095224a59ceb3f3db46b3f9767111a6850/src/OpenGL/libGLESv2/Texture.cpp
,
Jan 26 2018
The following revision refers to this bug: https://swiftshader.googlesource.com/SwiftShader.git/+/b64e0ceb39c57035ecc06d9f8e7c5dd1867442de commit b64e0ceb39c57035ecc06d9f8e7c5dd1867442de Author: Nicolas Capens <capn@google.com> Date: Fri Jan 26 13:34:18 2018 Fix missing comparison operators. The types can differ for many opcodes where the right-hand side is a constant, and this assert isn't that useful, so just remove the opcode checks. Bug chromium:805881 Change-Id: Ibcbda5123aaeaaf5753732d7cad4b5a3b331e963 Reviewed-on: https://swiftshader-review.googlesource.com/16730 Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> [modify] https://crrev.com/b64e0ceb39c57035ecc06d9f8e7c5dd1867442de/src/Reactor/SubzeroReactor.cpp
,
Jan 26 2018
The following revision refers to this bug: https://swiftshader.googlesource.com/SwiftShader.git/+/aa02848b8bd6436fe317bf8709ae0aec5d1fb1a8 commit aa02848b8bd6436fe317bf8709ae0aec5d1fb1a8 Author: Nicolas Capens <capn@google.com> Date: Fri Jan 26 13:34:18 2018 Fix memory leak on error. Bug chromium:805881 Change-Id: I2729fd81dbf2ac40bcfb5a0781cf57daefc4f75a Reviewed-on: https://swiftshader-review.googlesource.com/16748 Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> [modify] https://crrev.com/aa02848b8bd6436fe317bf8709ae0aec5d1fb1a8/src/OpenGL/compiler/Intermediate.cpp
,
Jan 26 2018
The following revision refers to this bug: https://swiftshader.googlesource.com/SwiftShader.git/+/c62fad3b19a06381ee9b82d84775698832cc4ea3 commit c62fad3b19a06381ee9b82d84775698832cc4ea3 Author: Nicolas Capens <capn@google.com> Date: Fri Jan 26 13:34:18 2018 Remove unnecessary pointer checks. VertexProgram and PixelProgram always have a shader. Bug chromium:805881 Change-Id: I0a27b4e7a0bc0ae591d89eb295e215bd421416fb Reviewed-on: https://swiftshader-review.googlesource.com/16749 Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> [modify] https://crrev.com/c62fad3b19a06381ee9b82d84775698832cc4ea3/src/Shader/PixelProgram.hpp [modify] https://crrev.com/c62fad3b19a06381ee9b82d84775698832cc4ea3/src/Shader/VertexProgram.cpp
,
Jan 26 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/65544d7add9aa3c7facc2df523e12f2d4163ea9b commit 65544d7add9aa3c7facc2df523e12f2d4163ea9b Author: Lei Zhang <thestig@chromium.org> Date: Fri Jan 26 15:31:10 2018 Fix potential memory leak in CCodec_JpegModule::Start(). BUG=chromium:805881 Change-Id: I91266367296218998d011dd5f62e0b4c6df291a3 Reviewed-on: https://pdfium-review.googlesource.com/24070 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> [modify] https://crrev.com/65544d7add9aa3c7facc2df523e12f2d4163ea9b/core/fxcodec/codec/fx_codec_jpeg.cpp
,
Jan 26 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/1d746208a1335a192433923b4a818ded3978228d commit 1d746208a1335a192433923b4a818ded3978228d Author: Mike Klein <mtklein@chromium.org> Date: Fri Jan 26 15:37:48 2018 bug fixes from PVS Studio (static analysis) - Hal, please check out SkPDFCanon... was this unused? - Cary, please SkOpContour... is it right that allDone isn't necessary? - Brian, the rest? Bug: chromium:805881 Change-Id: I7cbbcf44f4460a114f4ed2a59ed3856203049cdc Reviewed-on: https://skia-review.googlesource.com/99960 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> [modify] https://crrev.com/1d746208a1335a192433923b4a818ded3978228d/src/gpu/gl/builders/GrGLProgramBuilder.cpp [modify] https://crrev.com/1d746208a1335a192433923b4a818ded3978228d/src/pathops/SkOpContour.cpp [modify] https://crrev.com/1d746208a1335a192433923b4a818ded3978228d/src/pdf/SkPDFCanon.h [modify] https://crrev.com/1d746208a1335a192433923b4a818ded3978228d/src/core/SkPathRef.cpp [modify] https://crrev.com/1d746208a1335a192433923b4a818ded3978228d/src/gpu/gl/GrGLGpu.cpp [modify] https://crrev.com/1d746208a1335a192433923b4a818ded3978228d/src/gpu/ops/GrNonAAFillRectOp.cpp
,
Jan 26 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/636e82c0a73ea6eb67074887f065d20e455bda97 commit 636e82c0a73ea6eb67074887f065d20e455bda97 Author: Lei Zhang <thestig@chromium.org> Date: Fri Jan 26 19:58:09 2018 Fix a wrong variable check in CFX_BilinearMatrix. This has existed since the initial PDFium check in. BUG=chromium:805881 Change-Id: I34b79d61c753d15d0f112c12f3dee43973403673 Reviewed-on: https://pdfium-review.googlesource.com/24090 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> [modify] https://crrev.com/636e82c0a73ea6eb67074887f065d20e455bda97/core/fxge/dib/cfx_imagetransformer.cpp
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0605cb553fa0b2842fc3bbb8dd68b2fe93f533a commit f0605cb553fa0b2842fc3bbb8dd68b2fe93f533a Author: Aleks Totic <atotic@chromium.org> Date: Fri Jan 26 22:09:00 2018 [LayoutNG] Fix copy pasted code bug Got reported by automated linter at: https://bugs.chromium.org/p/chromium/issues/detail?id=805881 Bug: 805881 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia11917484274dda0c2f3f3914da3dce37376e2fe Reviewed-on: https://chromium-review.googlesource.com/887748 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#532073} [modify] https://crrev.com/f0605cb553fa0b2842fc3bbb8dd68b2fe93f533a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
,
Jan 27 2018
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/953e60df08615aa7543602debecb0914f144f78a commit 953e60df08615aa7543602debecb0914f144f78a Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Sat Jan 27 07:51:22 2018 Roll src/third_party/pdfium/ b9ec0b31a..6e8a3e62e (11 commits) https://pdfium.googlesource.com/pdfium.git/+log/b9ec0b31a932..6e8a3e62e171 $ git log b9ec0b31a..6e8a3e62e --date=short --no-merges --format='%ad %ae %s' 2018-01-26 xlou Code cleanup - create a new function GetPageNumbers 2018-01-26 thestig Fix a wrong variable check in CFX_BilinearMatrix. 2018-01-26 thestig Pass nullptr to ParseContentWithParams() instead of 0. 2018-01-26 rharrison Clean up construction of CFX_Barcode 2018-01-26 hnakashima Fix crash in palette loading with Pattern colorspace. 2018-01-26 thestig Change CPDF_RenderStatus::ProcessPathPattern() to pass by pointer. 2018-01-26 thestig Mark some fxge class members as const. 2018-01-26 thestig Fix potential memory leak in CCodec_JpegModule::Start(). 2018-01-25 hnakashima Add timeout when downloading gold json. 2018-01-25 hnakashima Make private some methods in CPDF_DIBSource. 2018-01-25 dsinclair Remove empty FF classes Created with: roll-dep src/third_party/pdfium BUG=805881,805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibaba86271a00d1311dbaabadb5e07683f63db4e3 Reviewed-on: https://chromium-review.googlesource.com/890340 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532200} [modify] https://crrev.com/953e60df08615aa7543602debecb0914f144f78a/DEPS
,
Jan 29 2018
,
Jan 29 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/dbac8ca4f5d70195b0d8d6b7a0f042efb8e45574 commit dbac8ca4f5d70195b0d8d6b7a0f042efb8e45574 Author: Ryan Harrison <rharrison@chromium.org> Date: Mon Jan 29 14:53:57 2018 Fix typo introduced in cleanup of IsHyphen Introduced here https://pdfium-review.googlesource.com/#/c/17950/5/core/fpdftext/cpdf_textpage.cpp@1237 BUG=chromium:805881 Change-Id: I0c9109f3eebec968360734ff4d9d0542881d6823 Reviewed-on: https://pdfium-review.googlesource.com/24210 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> [modify] https://crrev.com/dbac8ca4f5d70195b0d8d6b7a0f042efb8e45574/core/fpdftext/cpdf_textpage.cpp
,
Jan 29 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/580f5dc88e3cbe8ed08661b829e2f560870e8b71 commit 580f5dc88e3cbe8ed08661b829e2f560870e8b71 Author: Lei Zhang <thestig@chromium.org> Date: Mon Jan 29 15:20:36 2018 Remove duplicate assignments in sycc420_to_rgb(). BUG=chromium:805881 Change-Id: I3b4914325833c859285a4af1f6e326872cbf1b18 Reviewed-on: https://pdfium-review.googlesource.com/24091 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> [modify] https://crrev.com/580f5dc88e3cbe8ed08661b829e2f560870e8b71/core/fxcodec/codec/fx_codec_jpx_opj.cpp
,
Jan 29 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/bc4869293d7869c06e3f8c18241447ec5b701b58 commit bc4869293d7869c06e3f8c18241447ec5b701b58 Author: Lei Zhang <thestig@chromium.org> Date: Mon Jan 29 15:30:46 2018 Fix identical if/else blocks. The CPWL_EditImpl::Backspace() instance occurred in commit 671a799. The other two instances where known cases. BUG=chromium:805881 Change-Id: Iae7cb8534e85342069d8753ced88543dad751e92 Reviewed-on: https://pdfium-review.googlesource.com/24050 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> [modify] https://crrev.com/bc4869293d7869c06e3f8c18241447ec5b701b58/fpdfsdk/pwl/cpwl_edit_impl.cpp [modify] https://crrev.com/bc4869293d7869c06e3f8c18241447ec5b701b58/core/fpdfdoc/cpdf_formfield.cpp [modify] https://crrev.com/bc4869293d7869c06e3f8c18241447ec5b701b58/fxjs/cjs_field.cpp
,
Jan 29 2018
First 3 articles (3/7): 1. Nice Chromium and clumsy memset - https://www.viva64.com/en/b/0553/ 2. break и fallthrough - https://www.viva64.com/en/b/0554/ 3. Chromium: Memory Leaks - https://www.viva64.com/en/b/0555/
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9102c8da1368baf479786b72951c06a082cdfa65 commit 9102c8da1368baf479786b72951c06a082cdfa65 Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Mon Jan 29 17:08:32 2018 Roll src/third_party/pdfium/ 6e8a3e62e..dbac8ca4f (1 commit) https://pdfium.googlesource.com/pdfium.git/+log/6e8a3e62e171..dbac8ca4f5d7 $ git log 6e8a3e62e..dbac8ca4f --date=short --no-merges --format='%ad %ae %s' 2018-01-29 rharrison Fix typo introduced in cleanup of IsHyphen Created with: roll-dep src/third_party/pdfium BUG=805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I889d9a09816c347b29c300e25a372bae61acb5db Reviewed-on: https://chromium-review.googlesource.com/891299 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532467} [modify] https://crrev.com/9102c8da1368baf479786b72951c06a082cdfa65/DEPS
,
Jan 29 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/2f7a01849e698b3d63e79d7e8bf04a6346fa248e commit 2f7a01849e698b3d63e79d7e8bf04a6346fa248e Author: Lei Zhang <thestig@chromium.org> Date: Mon Jan 29 17:32:36 2018 Remove redundant checks in CPVT_WordRange::Intersect(). BUG=chromium:805881 Change-Id: I5ff76067fb26198df13482e6c475138142b3f6c5 Reviewed-on: https://pdfium-review.googlesource.com/24192 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> [modify] https://crrev.com/2f7a01849e698b3d63e79d7e8bf04a6346fa248e/core/fpdfdoc/cpvt_wordrange.h
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6c8e45c35e7d045f18867c161adc6a13897546b commit a6c8e45c35e7d045f18867c161adc6a13897546b Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Mon Jan 29 18:22:15 2018 Roll src/third_party/pdfium/ dbac8ca4f..bc4869293 (3 commits) https://pdfium.googlesource.com/pdfium.git/+log/dbac8ca4f5d7..bc4869293d78 $ git log dbac8ca4f..bc4869293 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 thestig Fix identical if/else blocks. 2018-01-29 thestig Remove duplicate assignments in sycc420_to_rgb(). 2018-01-29 thestig Roll V8 to ee5d9a0c. Created with: roll-dep src/third_party/pdfium BUG=805881,805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id658b85157c1332418f1509c8653ecab8390cfae Reviewed-on: https://chromium-review.googlesource.com/890631 Commit-Queue: <pdfium-deps-roller@chromium.org> Reviewed-by: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532498} [modify] https://crrev.com/a6c8e45c35e7d045f18867c161adc6a13897546b/DEPS
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dbb15c97ddab0f18bb8f7ae55c9482056d3649b commit 2dbb15c97ddab0f18bb8f7ae55c9482056d3649b Author: Nico Weber <thakis@chromium.org> Date: Mon Jan 29 18:29:06 2018 Remove unneeded null checks in ImageBitmap.cpp. `new` never returns nullptr per standard (in Chromium, we crash the process on out-of-memory instead). Also, in the first case, the image in the ImageBitmap is checked for nullness right above, so that check isn't needed either. Bug: 805881 Change-Id: Ieff5bdf15813bfb0f3087ec925f74ecacc77df7c Reviewed-on: https://chromium-review.googlesource.com/887758 Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532503} [modify] https://crrev.com/2dbb15c97ddab0f18bb8f7ae55c9482056d3649b/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a771ffc221bc8b3bd9bfdb447a7b65059e6c6c5d commit a771ffc221bc8b3bd9bfdb447a7b65059e6c6c5d Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Tue Jan 30 00:33:04 2018 Roll src/third_party/pdfium/ bc4869293..95b232f79 (10 commits) https://pdfium.googlesource.com/pdfium.git/+log/bc4869293d78..95b232f79123 $ git log bc4869293..95b232f79 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 dsinclair Cleanup some ChoiceList code 2018-01-29 dsinclair Add common base class between CXFA_FFComboBox and CXFA_FFListBox 2018-01-29 dsinclair Cleanup CXFA_Node visibility 2018-01-29 dsinclair Fold single caller methods into callsite 2018-01-29 dsinclair Move barcode code to CXFA_Barcode 2018-01-29 xlou Change pageNums from uint16_t to uint32_t 2018-01-29 tsepez Kill some bare |new|s in cjs_field.cpp 2018-01-29 dsinclair Cleanup the FFWidget determination code. 2018-01-29 thestig Clean up FPDF_GetFormType(). 2018-01-29 thestig Remove redundant checks in CPVT_WordRange::Intersect(). Created with: roll-dep src/third_party/pdfium BUG=805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0e74766457e7612a54d88724144921f64c640699 Reviewed-on: https://chromium-review.googlesource.com/892044 Commit-Queue: <pdfium-deps-roller@chromium.org> Reviewed-by: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532696} [modify] https://crrev.com/a771ffc221bc8b3bd9bfdb447a7b65059e6c6c5d/DEPS
,
Jan 30 2018
4. Chromium: Typos - https://www.viva64.com/en/b/0556/ P.S. I can't stand looking at bugs fixing based on a text report with no possible navigation. It is so inconvenient! Moreover, it is ineffective as it is a one-time check, but not a regular code control. I suggest considering the use of PVS-Studio to check the code of Chromium, Chrome, and other projects.
,
Jan 30 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/95dd8dad6b1b2ac31aca84afe677205c7ed47f7f commit 95dd8dad6b1b2ac31aca84afe677205c7ed47f7f Author: Lei Zhang <thestig@chromium.org> Date: Tue Jan 30 18:31:40 2018 Remove not reachable branch in fxge code. BUG=chromium:805881 Change-Id: I5f920649f425d0cfc47c780b36ed70f23cbe1299 Reviewed-on: https://pdfium-review.googlesource.com/24191 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> [modify] https://crrev.com/95dd8dad6b1b2ac31aca84afe677205c7ed47f7f/core/fxge/win32/fx_win32_gdipext.cpp [modify] https://crrev.com/95dd8dad6b1b2ac31aca84afe677205c7ed47f7f/core/fxge/skia/fx_skia_device.cpp [modify] https://crrev.com/95dd8dad6b1b2ac31aca84afe677205c7ed47f7f/core/fxge/win32/cfx_psrenderer.cpp [modify] https://crrev.com/95dd8dad6b1b2ac31aca84afe677205c7ed47f7f/core/fxge/win32/fx_win32_device.cpp [modify] https://crrev.com/95dd8dad6b1b2ac31aca84afe677205c7ed47f7f/core/fxge/skia/fx_skia_device.h
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18f244635e321ec2e54862186f5727cb29ce8309 commit 18f244635e321ec2e54862186f5727cb29ce8309 Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jan 31 01:02:34 2018 Roll src/third_party/pdfium/ 1917cdd8c..233466005 (15 commits) https://pdfium.googlesource.com/pdfium.git/+log/1917cdd8c90b..2334660053e0 $ git log 1917cdd8c..233466005 --date=short --no-merges --format='%ad %ae %s' 2018-01-30 npm Use unsigned for char width 2018-01-30 dsinclair Shuffle more code out of CXFA_Node 2018-01-30 dsinclair Move CheckButton code from CXFA_Node to CXFA_CheckButton 2018-01-30 rharrison Clean up CSS Data Table entries and access 2018-01-30 tsepez Remove bare new from JS_Define.h 2018-01-30 hnakashima Check if opj_image_data_alloc returned null. 2018-01-30 dsinclair Cleanup some param passing code 2018-01-30 hnakashima Guard usages of tellp(). It may return -1 in error cases. 2018-01-30 dsinclair Cleanup duplicate RunScript code 2018-01-30 thestig Remove not reachable branch in fxge code. 2018-01-30 thestig Use anonymous namespace in gdiplus code. 2018-01-30 dsinclair Cleanup some SDK code 2018-01-30 tsepez Revert "Revert "Use UnownedPtr instead of T* in MaybeOwned."" 2018-01-30 tsepez Revert "Use UnownedPtr instead of T* in MaybeOwned." 2018-01-30 tsepez Use UnownedPtr instead of T* in MaybeOwned. Created with: roll-dep src/third_party/pdfium BUG= 807214 ,805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iccd05c3211b080fc7392a482d0c2be722c1ec683 Reviewed-on: https://chromium-review.googlesource.com/894482 Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533128} [modify] https://crrev.com/18f244635e321ec2e54862186f5727cb29ce8309/DEPS
,
Jan 31 2018
5. Chromium: Use of Untrusted Data - https://www.viva64.com/en/b/0557/ P.S. I’d like to remind that in the text document only a part of errors is given, which drew my attention when looking through the analysis. It is irrational to fix only a part of bugs. My idea was to interest the developers with the abilities of PVS-Studio so that with its help they could check more thoroughly various projects. Anyway, my mail is so far quiet and no one asks questions related to running and using of PVS-Studio :).
,
Feb 1 2018
6. Why it is important to check what the malloc function returned - https://www.viva64.com/en/b/0558/
,
Feb 2 2018
7. The End. Chromium: Miscellaneous Defects - https://www.viva64.com/en/b/0559/
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb83e91a32e5efcadd7ee10f5731df8dce3cc448 commit bb83e91a32e5efcadd7ee10f5731df8dce3cc448 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Feb 02 22:00:15 2018 Avoid undefined order of evaluation in DeviceMediaAsyncFileUtil::CreateOrOpen Since there are no sequencing guarantees when evaluating function arguments, it's possible that context could be dereferenced after the state has already been consumed by the move constructor. Bug: 805881 Change-Id: Ia23c0dc593a08d024392918dcb6988f6e07dd68d Reviewed-on: https://chromium-review.googlesource.com/900045 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#534165} [modify] https://crrev.com/bb83e91a32e5efcadd7ee10f5731df8dce3cc448/chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/428f6f6cdddde81111fb27fc26e59342c9ecdbc7 commit 428f6f6cdddde81111fb27fc26e59342c9ecdbc7 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Feb 02 23:58:24 2018 IsKeyboardPresentOnSlate(): null check before assigning to result Bug: 805881 Change-Id: I29434a3e34a816412696188674ae9ecf47e6fed6 Reviewed-on: https://chromium-review.googlesource.com/899945 Reviewed-by: Justin Schuh <jschuh@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534204} [modify] https://crrev.com/428f6f6cdddde81111fb27fc26e59342c9ecdbc7/base/win/win_util.cc
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1ebe528ff18c71c1e8e23c50ddc64404f03bd69 commit d1ebe528ff18c71c1e8e23c50ddc64404f03bd69 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Feb 02 23:58:53 2018 Fix undefined sequencing in trace_log.cc Prior to C++17, it's not defined if the LHS or RHS of an assignment is evaluated first: the only that's defined is the evaluation of the LHS and RHS happen before the assignment. Bug: 805881 Change-Id: Ieece0dd53f174d82a8e32ff41418e894f0c27ddd Reviewed-on: https://chromium-review.googlesource.com/899948 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534205} [modify] https://crrev.com/d1ebe528ff18c71c1e8e23c50ddc64404f03bd69/base/trace_event/trace_log.cc
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb5c4ce87f6cdbebdb43687d519aefb5c5f25bd9 commit cb5c4ce87f6cdbebdb43687d519aefb5c5f25bd9 Author: Daniel Cheng <dcheng@chromium.org> Date: Sat Feb 03 05:42:15 2018 Actually erase dead InterfacePtrs in pdf_to_emf_converter.cc Despite the name, std::remove_if() doesn't actually remove elements from a container: it merely shuffles the elements so the ones that fail the predicate are at the end and can be easily erased. Bug: 805881 Change-Id: I3bb4894af565784eb05c8f870415d38393ec69a4 Reviewed-on: https://chromium-review.googlesource.com/900136 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534262} [modify] https://crrev.com/cb5c4ce87f6cdbebdb43687d519aefb5c5f25bd9/chrome/services/printing/pdf_to_emf_converter.cc
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/085bf44f0484f4d0a14c9fa07a8404dcb1296f31 commit 085bf44f0484f4d0a14c9fa07a8404dcb1296f31 Author: Daniel Cheng <dcheng@chromium.org> Date: Sat Feb 03 14:33:31 2018 Propagate delete failed out of DeleteRegistryValueIf Bug: 805881 Change-Id: I73ac95685fca8f3b68a81bbaab3f915b51dc335e Reviewed-on: https://chromium-review.googlesource.com/899953 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#534273} [modify] https://crrev.com/085bf44f0484f4d0a14c9fa07a8404dcb1296f31/chrome/installer/util/install_util.cc
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f699c2f8929d8694abce38cee336b1cb60166eaf commit f699c2f8929d8694abce38cee336b1cb60166eaf Author: Daniel Cheng <dcheng@chromium.org> Date: Mon Feb 05 19:16:26 2018 Initialize the return value of NetworkingPrivateServiceClient::GetEnabledNetworkTypes Otherwise, appending a string will simply crash. Bug: 805881 Change-Id: I9a8893c3cafcc41d5d1df55394f8bc07925e8ba5 Reviewed-on: https://chromium-review.googlesource.com/900056 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534450} [modify] https://crrev.com/f699c2f8929d8694abce38cee336b1cb60166eaf/extensions/browser/api/networking_private/networking_private_service_client.cc
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79ee49c3ca5abee074b3858aae43f353d3c13101 commit 79ee49c3ca5abee074b3858aae43f353d3c13101 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Feb 09 20:41:25 2018 Use logical || instead of bitwise | in AppViewGuest::CreateWebContents. Bug: 805881 Change-Id: I998399ae8ce53fc8a89fa2adebed61f009794d46 Reviewed-on: https://chromium-review.googlesource.com/900054 Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#535814} [modify] https://crrev.com/79ee49c3ca5abee074b3858aae43f353d3c13101/extensions/browser/guest_view/app_view/app_view_guest.cc
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c90b4a4e36e19ab803ef0e40501df84d3a9330b5 commit c90b4a4e36e19ab803ef0e40501df84d3a9330b5 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Feb 09 21:58:11 2018 Don't shadow assignment of sign in device ID in the non-local sync case. Bug: 805881 Change-Id: I23791cc4aa38ae53501ae3cdb6d1055b31ea4fa2 Reviewed-on: https://chromium-review.googlesource.com/900058 Reviewed-by: Nicolas Zea <zea@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#535841} [modify] https://crrev.com/c90b4a4e36e19ab803ef0e40501df84d3a9330b5/components/browser_sync/profile_sync_service.cc
,
Feb 12 2018
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9278caf2a776aba38719a29c0bc64a30c5ed55fe commit 9278caf2a776aba38719a29c0bc64a30c5ed55fe Author: Nico Weber <thakis@chromium.org> Date: Mon Feb 12 02:44:55 2018 Fix a too-small memset. Found by PVS-Studio. Bug: 805881 Change-Id: I96cd4b37494514ae784a2583d31738e8d3ef616a Reviewed-on: https://chromium-review.googlesource.com/912252 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536024} [modify] https://crrev.com/9278caf2a776aba38719a29c0bc64a30c5ed55fe/content/renderer/pepper/event_conversion.cc
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a6a9b1462ba6b6d50a21f489db4f5fd782e1ef4 commit 2a6a9b1462ba6b6d50a21f489db4f5fd782e1ef4 Author: Daniel Cheng <dcheng@chromium.org> Date: Mon Feb 12 19:56:40 2018 AXPlatformNodeWin::HandleSpecialTextOffset: clamp selection_end to non-negative values. Bug: 805881 Change-Id: I9848712d79cd60288cb8f5e92c5f67177063a2d6 Reviewed-on: https://chromium-review.googlesource.com/900065 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#536164} [modify] https://crrev.com/2a6a9b1462ba6b6d50a21f489db4f5fd782e1ef4/ui/accessibility/platform/ax_platform_node_win.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 25 2018