New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805849 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OoO until Feb 4th
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 39240



Sign in to add a comment

third_party/metrics_proto fails tools/license.py

Project Member Reported by raphael....@intel.com, Jan 25 2018

Issue description

The "URL" field in README.chromium is not optional. Running //tools/licenses.py causes it to fail when scanning //third_party/metrics_proto:

    licenses.LicenseError: couldn't find 'URL' line in README.chromium or licences.py SPECIAL_CASES                     

 
Owner: holte@chromium.org
Sounds like we need to add to licences.py SPECIAL_CASES?

Steve, you set this up - can you take a look?
Cc: dpranke@chromium.org
Actually, SPECIAL_CASES is just a replacement for README.chromium. It doesn't have a mechanism for omitting the URL.

In this case, there is no URL because third_party/metrics_proto is the canonical public repository for this code, since upstream is in an internal google3 repository. +dpranke to advise on how best to handle this.
maybe just add www.google.com and a comment?
Blocking: 39240
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3db9c7163f755534cf980a81904bec6cef41175

commit a3db9c7163f755534cf980a81904bec6cef41175
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Tue Mar 13 22:07:48 2018

metrics_proto: Set URL and Short Name in README.chromium

The URL field is not optional in README.chromium, so //tools/licenses.py is
currently failing with

    licenses.LicenseError: couldn't find 'URL' line in README.chromium or licences.py SPECIAL_CASES

in //third_party/metrics_proto.

The actual development repository is not public, and the code in the
Chromium tree acts as the canonical public repository. Add an explanation
instead of a URL in a similar fashion to what is already done in:
* //third_party/bazel/desugar
* //third_party/gvr-android-keyboard
* //third_party/instrumented_libraries
* //third_party/s2cellid

While here, also set a Short Name; even though licenses.py does not
complain, README.chromium.template does not say it is an optional field.

Bug:  805849 
Change-Id: I1810e8523a2d3bd210855b2a7c1f997fdb0c7dda
Reviewed-on: https://chromium-review.googlesource.com/960028
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#542933}
[modify] https://crrev.com/a3db9c7163f755534cf980a81904bec6cef41175/third_party/metrics_proto/README.chromium

Labels: M-67
Owner: raphael....@intel.com
Status: Fixed (was: Untriaged)

Sign in to add a comment