New issue
Advanced search Search tips

Issue 805846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Add blur + vibrancy effect to the toolbar and the omnibox.

Project Member Reported by gambard@chromium.org, Jan 25 2018

Issue description

For the omnibox, add black background with alpha.
For incognito, use blur effect "dark".
 

Comment 1 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 2 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Labels: -Q2 Q1
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d42436e977f8470950d04d691e0f65ab23e00d0

commit 4d42436e977f8470950d04d691e0f65ab23e00d0
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Feb 01 12:55:34 2018

Add blur effect to the toolbar

This CL adds a blur effect to the toolbar's background, to see the
content of the page below.

Screenshot: https://drive.google.com/file/d/1MB5lyrozQ3OkEenWtXi3MWfOy0e2hwxx/view

Bug:  805846 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib12dd0396fbfef9868d352e92a9ec0981aa091df
Reviewed-on: https://chromium-review.googlesource.com/897323
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533645}
[modify] https://crrev.com/4d42436e977f8470950d04d691e0f65ab23e00d0/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/4d42436e977f8470950d04d691e0f65ab23e00d0/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/4d42436e977f8470950d04d691e0f65ab23e00d0/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/4d42436e977f8470950d04d691e0f65ab23e00d0/ios/chrome/browser/ui/toolbar/clean/toolbar_configuration.h
[modify] https://crrev.com/4d42436e977f8470950d04d691e0f65ab23e00d0/ios/chrome/browser/ui/toolbar/clean/toolbar_configuration.mm
[modify] https://crrev.com/4d42436e977f8470950d04d691e0f65ab23e00d0/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.h
[modify] https://crrev.com/4d42436e977f8470950d04d691e0f65ab23e00d0/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.mm

Status: Fixed (was: Assigned)
Only blur effect added as the vibrancy effect doesn't look right.

Sign in to add a comment