New issue
Advanced search Search tips

Issue 805845 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Change the WKWebView such as it is scrolling below the toolbar.

Project Member Reported by gambard@chromium.org, Jan 25 2018

Issue description

For now the WKWebView is only displayed in the visible content of the page. It should be displayed below the toolbar (including the status bar), so it is possible to see it through the toolbar.
 
Labels: large

Comment 2 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 3 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9eba1f53b349e430119dc7a1c6a9916ba975613

commit e9eba1f53b349e430119dc7a1c6a9916ba975613
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 31 09:54:55 2018

Display WKWebView below the toolbar

This CL changes the scroll view of the WKWebView used in
CRWWebViewContentView so it doesn't clips to bound its content.
It allows the content of the WebView to be fully displayed on the page,
including below the toolbar.

Bug:  805845 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3591b354a21ebb7b9f29500bc93f697e37547129
Reviewed-on: https://chromium-review.googlesource.com/887041
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533242}
[modify] https://crrev.com/e9eba1f53b349e430119dc7a1c6a9916ba975613/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/e9eba1f53b349e430119dc7a1c6a9916ba975613/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
[modify] https://crrev.com/e9eba1f53b349e430119dc7a1c6a9916ba975613/ios/web/public/web_state/ui/crw_web_view_scroll_view_proxy.h
[modify] https://crrev.com/e9eba1f53b349e430119dc7a1c6a9916ba975613/ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm
[modify] https://crrev.com/e9eba1f53b349e430119dc7a1c6a9916ba975613/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm

Labels: -large medium
Status: Fixed (was: Assigned)
Labels: -Q2 Q1

Sign in to add a comment