Regression: [DevTools] Suggestion list doesn't appear for any letter under 'Watch' section.
Reported by
dchau...@etouch.net,
Jan 25 2018
|
|||||||||||
Issue descriptionChrome Version: 65.0.3325.18 (Official Build) 8537a0b30e659eefb087ec25b97a1a7f61e2d672-refs/branch-heads/3325@{#78} 32/64-bit. OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.3). What steps will reproduce the problem? 1. Launch Chrome, open DevTools window and go to Sources section. 2. Go to 'Watch' section and click on '+' icon to add expression. 3. Now type letter 'W' in text-box and observe. Suggestion list doesn't appear. Suggestion list should appear. This is a regression issue, broken in M-65 series, below is manual regression range. Good build: 65.0.3298.0 (Revision: 524618) Bad build: 65.0.3299.0 (Revision: 524906) Using the per-revision bisect providing the bisect results: You are probably looking for a change made after 524901 (known good), but no later than 524902 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/4a8a7f036f892bb69382220076743abfabfe9910..d5ed67e13e9939c00aed1876e8701cb47101cf6f Suspecting: https://chromium.googlesource.com/chromium/src/+/d5ed67e13e9939c00aed1876e8701cb47101cf6f @einbinder: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. NOTE: Issue is also reproducible on M-66 Canary build # 66.0.3331.0 Kindly review the attached screen-cast for reference. Thank you.
,
Jan 25 2018
marking as RBS, please change if required.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60d90d459261055fff4a1650b6d894b83bb43aa4 commit 60d90d459261055fff4a1650b6d894b83bb43aa4 Author: Joel Einbinder <einbinder@chromium.org> Date: Wed Jan 31 05:04:43 2018 DevTools: Fix autocomplete in watch sidebar Bug: 805837 Change-Id: Ib24d46b9ed98b1264c0ff009ac40846ce254c44f Reviewed-on: https://chromium-review.googlesource.com/887640 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#533205} [modify] https://crrev.com/60d90d459261055fff4a1650b6d894b83bb43aa4/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js [modify] https://crrev.com/60d90d459261055fff4a1650b6d894b83bb43aa4/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
,
Feb 1 2018
Update:- Tested this issue on Windows (7,8,10), Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS) machines using latest Chrome canary build# 66.0.3336.0 and fix is working as expected.. Hence adding TE Verified labels. Please find the attached screen-cast for reference. Thanks..!
,
Feb 2 2018
,
Feb 6 2018
einbinder@, Requesting above code merge to M65 as it is stable blocker for M65. Thanks..!
,
Feb 13 2018
M65 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Feb 15 2018
+ pfeldman@/dgozman@, do we need a merge for Cl listed at #3 to M65 branch 3325? If yes, pls request a merge ASAP.
,
Feb 15 2018
,
Feb 15 2018
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 15 2018
Approving merge for CL listed #3 to M65 branch 3325 based on comment #4. Please merge ASAP. Thank you. Also pls mark bug as fixed after the merge if nothing is pending.
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/206e764e4060a3aaa4008efc6431f99381d78d8d commit 206e764e4060a3aaa4008efc6431f99381d78d8d Author: Joel Einbinder <einbinder@chromium.org> Date: Thu Feb 15 23:03:58 2018 DevTools: Fix autocomplete in watch sidebar Bug: 805837 Change-Id: Ib24d46b9ed98b1264c0ff009ac40846ce254c44f Reviewed-on: https://chromium-review.googlesource.com/887640 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533205}(cherry picked from commit 60d90d459261055fff4a1650b6d894b83bb43aa4) Reviewed-on: https://chromium-review.googlesource.com/923061 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#484} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/206e764e4060a3aaa4008efc6431f99381d78d8d/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js [modify] https://crrev.com/206e764e4060a3aaa4008efc6431f99381d78d8d/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
,
Feb 20 2018
einbinder@, pls mark bug as fixed if nothing is pending.
,
Feb 20 2018
,
Feb 21 2018
Update:- Re-tested this issue on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) machines using latest Chrome Beta build# 65.0.3325.88 and fix is working as expected.. Hence adding TE Verified labels. Please find the attached screen-cast for reference. Thanks..! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by dchau...@etouch.net
, Jan 25 2018