Non-Regression : 'Full Screen' Icon is seen when video is playing in Full screen instead of 'Exit Full Screen' Icon in maximized window |
||||||||||||||
Issue descriptionChrome Version: 64.0.3282.117/10176.60.0 beta-channel Kip,Reks and Daisy. OS: Chrome Sample URL : http://www.sample-videos.com/ What steps will reproduce the problem? (1)Sign in to user ->Now go to above URL -> download any file (2)Now go to Files App -> Select downloaded video -> Right Click and select 'Open with Video Player' option (3)Now window should be maximized -> Click on 'Full screen' icon -> video will play in Full screen -> Now observe 'Exit Full Screen' Icon is not available instead 'Full screen' icon is only seen (Please refer Video and Screenshot) Note: 1. In Files App -> Select downloaded video -> Right Click and select 'Open with Video Player' option -> Window should not be in Maximized mode i.e. it should be in Resize mode -> now lick on 'Full screen' icon -> video will play in Full screen -> Now observe 'Exit Full Screen' Icon is seen (Please refer 'Expected_ ExitFullScreenIconInResizeMode' Video and Screenshot) 2.Issue is seen on M-63 Stable,M-65 dev-branch build and latest M-66 also Expected: 'Exit Full Screen' Icon should be seen when video is playing in Full screen mode in maximized window Actual: Instead 'Full Screen' Icon is seen when video is playing in Full screen mode This is Non-Regression Issue seen form M-62 @fukino : Please confirm the Issue
,
Feb 1 2018
I took a look at this as my first bug, but I wasn't able to replicate this problem. I always got the correct icon showing when I go to full screen. This was the case when using code at HEAD and also at tag 64.0.3282.117
,
Feb 2 2018
Thank you for looking into this one! (Let me update the owner) I was able to reproduce the issue on ToT, using ChromeOS on Linux and .webm video file. My procedure is as follows. 1) Download a webm file by "Save link as ..." context menu option on the first bunny thumbnail. 2) Click the download notification. You should click the area around "Download complete", not the "Show in folder" button. 3) Video player will open. Click the Maximize button, then click close button. 4) Repeat step 1-2. 5) Video player will open with maximized state, but it is not fullscreen state. It is expected that we see "Full screen" button. 6) Click the "Full screen" button. The video player goes to fullscreen mode, but the button icon is still "Full screen". It should be "Exit full screen" icon.
,
Feb 2 2018
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f7462ed1d041b4596a848d79c4fcbb0b4fbc2fa commit 4f7462ed1d041b4596a848d79c4fcbb0b4fbc2fa Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Feb 07 07:14:37 2018 Fix fullscreen icon when window is maximized When window goes from maximized to fullscreen, the onFullscreened event is fired. Also the onRestored event is fired since onRestored is called any time that a window moves out of maximized or minimized. So rather than have VideoControls.onFullScreenChanged take a boolean `fullscreen` var, it checks at runtime by calling util.isFullScreen. Bug: 805828 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I88b0e651effe8a50c498b2d0c6190eac63b8cad7 Reviewed-on: https://chromium-review.googlesource.com/906173 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#534942} [modify] https://crrev.com/4f7462ed1d041b4596a848d79c4fcbb0b4fbc2fa/ui/file_manager/video_player/js/media_controls.js [modify] https://crrev.com/4f7462ed1d041b4596a848d79c4fcbb0b4fbc2fa/ui/file_manager/video_player/js/video_player.js
,
Feb 9 2018
,
Feb 16 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by fukino@chromium.org
, Jan 25 2018