Setting NativePrintersBulkConfiguration does not show managed printers. |
|||||||||
Issue description
10323.1.0 (65.0.3325.9)
Example policy value:
"NativePrintersBulkConfiguration": {"url":"https://storage.googleapis.com/policy-test-files/test_file.json","hash":"094b28f117b002d3995c8dc2422e3d556b0d22aed525357f8dab03ca8efcac7e"}
"NativePrintersBulkAccessMode": 2
Whether using Yaps with these two policies set or using CPanel (managedchrome.com domain, which doesn't appear to set BulkAccessMode policy), no managed printers are seen.
The original NativePrinters policy does work.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36c0869fc5faa9f9a31a83ec8bfddf1e86e007f8 commit 36c0869fc5faa9f9a31a83ec8bfddf1e86e007f8 Author: Sean Kau <skau@chromium.org> Date: Mon Jan 29 18:42:49 2018 Change default access mode for bulk printer configurations Changing the default mode to AllAccess from BlacklistOnly. Changing the default so that we can show printers if the NativePrintersAccessMode policy is unset. Changes to policy_templates.json will be separate. Bug: 805825 Change-Id: I62ef189749ad2209ba715835e4a1ffda8150573e Reviewed-on: https://chromium-review.googlesource.com/887366 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#532508} [modify] https://crrev.com/36c0869fc5faa9f9a31a83ec8bfddf1e86e007f8/chrome/browser/chromeos/printing/external_printers_pref_bridge.cc
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50930c9816b0b93c27979593226fd48e93ba163d commit 50930c9816b0b93c27979593226fd48e93ba163d Author: Sean Kau <skau@chromium.org> Date: Fri Feb 02 03:24:59 2018 Convert ExternalPrintersFactory to WeakPtr We need notification of reference invalidation for ExternalPrinters objects. So, change to distributing WeakPtrs instead of raw pointers. Bug: 805825 Change-Id: I06aee8e91df490ceae8fd8fe671e31472ae316fd Reviewed-on: https://chromium-review.googlesource.com/891574 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#533945} [modify] https://crrev.com/50930c9816b0b93c27979593226fd48e93ba163d/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc [modify] https://crrev.com/50930c9816b0b93c27979593226fd48e93ba163d/chrome/browser/chromeos/printing/external_printers.h [modify] https://crrev.com/50930c9816b0b93c27979593226fd48e93ba163d/chrome/browser/chromeos/printing/external_printers_factory.cc [modify] https://crrev.com/50930c9816b0b93c27979593226fd48e93ba163d/chrome/browser/chromeos/printing/external_printers_factory.h [modify] https://crrev.com/50930c9816b0b93c27979593226fd48e93ba163d/chrome/browser/chromeos/printing/external_printers_pref_bridge.cc [modify] https://crrev.com/50930c9816b0b93c27979593226fd48e93ba163d/chrome/browser/chromeos/printing/synced_printers_manager.cc
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86324ffef6e8ac4e930bb23494cb92fe400da649 commit 86324ffef6e8ac4e930bb23494cb92fe400da649 Author: Sean Kau <skau@chromium.org> Date: Fri Feb 02 07:21:05 2018 Attach an observer for bulk user printers. Without this observer, we never see printers for the new policy. Bug: 805825 Change-Id: I4d5f0b3f3035e65572631c4464e795c5a56549c3 Reviewed-on: https://chromium-review.googlesource.com/887281 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#533984} [modify] https://crrev.com/86324ffef6e8ac4e930bb23494cb92fe400da649/chrome/browser/chromeos/printing/synced_printers_manager.cc
,
Feb 2 2018
,
Feb 2 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 5 2018
,
Feb 6 2018
Verified in canary 66.0.3341.0 kefka
,
Feb 6 2018
,
Feb 7 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2018
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d49581e1ccf52345dc82c17cbc3b70f305681f20 commit d49581e1ccf52345dc82c17cbc3b70f305681f20 Author: Sean Kau <skau@chromium.org> Date: Wed Feb 07 20:54:00 2018 Change default access mode for bulk printer configurations Changing the default mode to AllAccess from BlacklistOnly. Changing the default so that we can show printers if the NativePrintersAccessMode policy is unset. Changes to policy_templates.json will be separate. TBR=skau@chromium.org (cherry picked from commit 36c0869fc5faa9f9a31a83ec8bfddf1e86e007f8) Bug: 805825 Change-Id: I62ef189749ad2209ba715835e4a1ffda8150573e Reviewed-on: https://chromium-review.googlesource.com/887366 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532508} Reviewed-on: https://chromium-review.googlesource.com/906841 Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#370} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/d49581e1ccf52345dc82c17cbc3b70f305681f20/chrome/browser/chromeos/printing/external_printers_pref_bridge.cc
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb5c52aa799b868ab714197f6614a06183dd9b4b commit eb5c52aa799b868ab714197f6614a06183dd9b4b Author: Sean Kau <skau@chromium.org> Date: Wed Feb 07 21:02:21 2018 Convert ExternalPrintersFactory to WeakPtr We need notification of reference invalidation for ExternalPrinters objects. So, change to distributing WeakPtrs instead of raw pointers. TBR=skau@chromium.org (cherry picked from commit 50930c9816b0b93c27979593226fd48e93ba163d) Bug: 805825 Change-Id: I06aee8e91df490ceae8fd8fe671e31472ae316fd Reviewed-on: https://chromium-review.googlesource.com/891574 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533945} Reviewed-on: https://chromium-review.googlesource.com/906849 Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#371} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/eb5c52aa799b868ab714197f6614a06183dd9b4b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc [modify] https://crrev.com/eb5c52aa799b868ab714197f6614a06183dd9b4b/chrome/browser/chromeos/printing/external_printers.h [modify] https://crrev.com/eb5c52aa799b868ab714197f6614a06183dd9b4b/chrome/browser/chromeos/printing/external_printers_factory.cc [modify] https://crrev.com/eb5c52aa799b868ab714197f6614a06183dd9b4b/chrome/browser/chromeos/printing/external_printers_factory.h [modify] https://crrev.com/eb5c52aa799b868ab714197f6614a06183dd9b4b/chrome/browser/chromeos/printing/external_printers_pref_bridge.cc [modify] https://crrev.com/eb5c52aa799b868ab714197f6614a06183dd9b4b/chrome/browser/chromeos/printing/synced_printers_manager.cc
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/404fea65b0d611c5747b6fe7baeff5335311334d commit 404fea65b0d611c5747b6fe7baeff5335311334d Author: Sean Kau <skau@chromium.org> Date: Wed Feb 07 21:04:36 2018 Attach an observer for bulk user printers. Without this observer, we never see printers for the new policy. TBR=skau@chromium.org (cherry picked from commit 86324ffef6e8ac4e930bb23494cb92fe400da649) Bug: 805825 Change-Id: I4d5f0b3f3035e65572631c4464e795c5a56549c3 Reviewed-on: https://chromium-review.googlesource.com/887281 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533984} Reviewed-on: https://chromium-review.googlesource.com/906842 Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#372} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/404fea65b0d611c5747b6fe7baeff5335311334d/chrome/browser/chromeos/printing/synced_printers_manager.cc
,
Feb 10 2018
10323.27.0 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by skau@chromium.org
, Jan 25 2018