New issue
Advanced search Search tips

Issue 805806 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Cursor in 'Find In Page' box appears misplaced on resizing window.

Reported by vineetha...@etouch.net, Jan 25 2018

Issue description

Chrome Version: 65.0.3325.18 (Official Build) Revision 8537a0b30e659eefb087ec25b97a1a7f61e2d672-refs/branch-heads/3325@{#78} (32/64 bit)
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, open NTP.
2. Press Ctrl+F to open the 'Find In Page' box ,resize the window from RHS to the maximum and observe.

Actual Result: Cursor in 'Find In Page' box appears misplaced.
Expected Result: Cursor in 'Find In Page' box should not appear misplaced.

This is regression issue broken in ‘M-64’ and providing the bisect using per-revision bisect
Good build: 64.0.3256.0(Revision: 513349)
Bad build: 64.0.3257.0(Revision: 513642)

Kindly refer the Bisect-info:

You are probably looking for a change made after 513360 (known good), but no later than 513361 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/a28eb737c4c9424d7656ada19b688af854777968..1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

Suspect: https://chromium.googlesource.com/chromium/src/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

@tapted: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. This issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS) OS.
2. This issue is also seen on M65 Dev(build #65.0.3322.3) , M66 Canary(build #66.0.3330.0).

Thank You!

 
ActualVideo.mp4
621 KB View Download
ExpectedVideo.mp4
557 KB View Download
Labels: RegressedIn-64 Target-65 FoundIn-66 Target-66 FoundIn-64 FoundIn-65 Target-64

Comment 2 by tapted@chromium.org, Jan 30 2018

Cc: bsep@chromium.org
Labels: Proj-HarmonyDialogs
This is behind a flag until m66. Seems to be one of the more minor issues.
Labels: ET-MUM-Reported

Comment 4 by bsep@chromium.org, Feb 14 2018

Labels: -Pri-1 Pri-2
Owner: kylixrd@chromium.org
Load balancing to Allen, since he worked on the find bar.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15a431d1396d7502a3ff7037cfd71dffd54b3e30

commit 15a431d1396d7502a3ff7037cfd71dffd54b3e30
Author: Allen Bauer <kylixrd@chromium.org>
Date: Mon Mar 12 17:31:36 2018

Misplaced caret on Find Bar when resized too small.

This is a direct result of the Find Bar moving to under the OmniBox like a bubble and the added margins/spacing from Harmony.

Bug:  805806 
Change-Id: Ib618cb80148dd02c24e8f7cae5a011439813d4ea
Reviewed-on: https://chromium-review.googlesource.com/926715
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542528}
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/chrome/browser/ui/views/autofill/view_util.cc
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/ui/views/color_chooser/color_chooser_view.cc
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/ui/views/controls/textfield/textfield.h
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/ui/views/examples/box_layout_example.cc
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/ui/views/layout/box_layout.cc
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/ui/views/layout/box_layout.h
[modify] https://crrev.com/15a431d1396d7502a3ff7037cfd71dffd54b3e30/ui/views/layout/box_layout_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment