New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805794 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug



Sign in to add a comment

virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html, virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html are failing

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 25 2018

Issue description

Comment 1 by tasak@google.com, Jan 25 2018

Summary: virtual/threaded/animations/responsiveness/viewport-unit-transform-responsive.html, virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html are failing (was: 453d68bf-d257-4ded-9448-888bf5899073)
The followings are failing:
virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html
virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html

The followings are timed-out:
virtual/threaded/animations/responsive/viewport-unit-transform-responsive.html
virtual/threaded/animations/responsive/viewport-unit-translate-responsive.html

Comment 2 by tasak@google.com, Jan 25 2018

Labels: OS-Linux
I'm sorry. Win7 Tests (dbg)(1) is another issue.

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4e073bd69642d1b203b32f1efa193c4da0691e5

commit a4e073bd69642d1b203b32f1efa193c4da0691e5
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Thu Jan 25 07:05:09 2018

Sheriff: mark 3 tests as flaky on Linux

- virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html,
- virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html, and
- virtual/threaded/animations/responsive/viewport-unit-translate-responsive.html

TBR=joedow
NOTRY=true

Bug: 805794
Change-Id: Id7710e3d04f23d84ab289669c588f6c486803b71
Reviewed-on: https://chromium-review.googlesource.com/885667
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#531835}
[modify] https://crrev.com/a4e073bd69642d1b203b32f1efa193c4da0691e5/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f555d6ff2f3f0cd1defa0ab76621cb0627444dd

commit 5f555d6ff2f3f0cd1defa0ab76621cb0627444dd
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Jan 25 13:36:09 2018

Mark virtual/threaded/animations/responsive/viewport-unit-translate-responsive.html as slow.

TBR=joedow
NOTRY=true

Bug: 805794
Change-Id: Ic54f541b8d5b3dd4905830fe39acd7dd42b9911c
Reviewed-on: https://chromium-review.googlesource.com/886681
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531881}
[modify] https://crrev.com/5f555d6ff2f3f0cd1defa0ab76621cb0627444dd/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/5f555d6ff2f3f0cd1defa0ab76621cb0627444dd/third_party/WebKit/LayoutTests/TestExpectations

Labels: Sheriff-Chromium
virtual/threaded/animations/responsive/viewport-unit-translate-responsive.html is still timing out on Linux Trusty and Linux Trusty Leak after being marked as SLOW. I'm going to change the expectation to TIMEOUT.


Project Member

Comment 6 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6f2f683304d7d2c158be2601554945ead6e49a

commit da6f2f683304d7d2c158be2601554945ead6e49a
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Jan 25 19:26:36 2018

Add TIMEOUT expectation for viewport-unit-translate-responsive.html

Tbr: vasilii@chromium.org
Bug: 805794
Change-Id: I958d1d6a1bce99a7213ad603be75204d35d342c0
Reviewed-on: https://chromium-review.googlesource.com/887161
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531976}
[modify] https://crrev.com/da6f2f683304d7d2c158be2601554945ead6e49a/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/da6f2f683304d7d2c158be2601554945ead6e49a/third_party/WebKit/LayoutTests/TestExpectations

Components: Blink>Animation
Labels: -Sheriff-Chromium
Owner: ericwilligers@chromium.org
Reassigning to ericwilligers@.

It may be a bug that the test doesn't completes.
Owner: flackr@chromium.org
Reassigning to new animation team.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d933fd0dcc4afc837a347fdae72b809c502f6c6

commit 8d933fd0dcc4afc837a347fdae72b809c502f6c6
Author: Kevin McNee <mcnee@chromium.org>
Date: Thu Feb 08 21:30:05 2018

Disable viewport-unit-transform-responsive.html and viewport-unit-translate-responsive.html on Mac

These tests were already flaky on Windows and Linux and now they've
started flaking on Mac.

NOTRY=true
TBR=fsamuel@chromium.org

Bug:  805788 , 805794
Change-Id: I2b655abe10e13f8d458740d3f1d6cb5d1c0e58ce
Reviewed-on: https://chromium-review.googlesource.com/909721
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535522}
[modify] https://crrev.com/8d933fd0dcc4afc837a347fdae72b809c502f6c6/third_party/WebKit/LayoutTests/TestExpectations

Cc: fsam...@chromium.org ccameron@chromium.org
Labels: OS-Mac
This may be related to  crbug.com/805788 
See  crbug.com/805788#c4 
Labels: Test-Layout Type-Bug
Owner: yigu@chromium.org
Status: Assigned (was: Available)
Cc: yigu@chromium.org
Labels: Test-Flaky
Owner: smcgruer@chromium.org
Status: Started (was: Assigned)
The animation test appears to no longer be Timeout flaky:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=viewport-unit-translate-responsive.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=viewport-unit-translate-responsive.html

I'm going to attempt to re-enable it.
Summary: virtual/threaded/animations/responsiveness/viewport-unit-translate-responsive.html, virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html are failing (was: virtual/threaded/animations/responsiveness/viewport-unit-transform-responsive.html, virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html are failing)
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b941a168d9c7827fe8680e6372cca8ea25896a8

commit 5b941a168d9c7827fe8680e6372cca8ea25896a8
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Jun 11 15:17:33 2018

Re-enable two animations test that no longer appear to be flaky

This is a speculative re-enabling based on the testharness dashboard
appearing green for both these tests.

Bug: 805794,  805788 
Change-Id: Ibfe69c9882a8ec1534329fe568b846d8c1cf8750
Reviewed-on: https://chromium-review.googlesource.com/1094979
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566003}
[modify] https://crrev.com/5b941a168d9c7827fe8680e6372cca8ea25896a8/third_party/WebKit/LayoutTests/TestExpectations

Cc: bokan@chromium.org wangxianzhu@chromium.org smcgruer@chromium.org
Components: -Blink>Animation Test>Android
Owner: ----
Status: Available (was: Started)
Summary: virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html, virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html are failing (was: virtual/threaded/animations/responsiveness/viewport-unit-translate-responsive.html, virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html are failing)
Removing the animation test from the name since I've speculatively re-enabled it. Not sure about the other two Android tests - setting a vaguely related component and cc-ing a few people who have touched those tests.

Comment 17 by bokan@chromium.org, Jun 11 2018

Owner: bokan@chromium.org
Status: Assigned (was: Available)
rootscroller is me.

Comment 18 by bokan@chromium.org, Jun 11 2018

Components: Blink>Scroll
Cc: -ccameron@chromium.org

Sign in to add a comment