New issue
Advanced search Search tips

Issue 805784 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 23
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 714962



Sign in to add a comment

LayoutNG sometimes misses updating inline node data

Project Member Reported by yosin@chromium.org, Jan 25 2018

Issue description

Following two tests uses node inline data for offset mapping but it is
unavailable even if layout clean state.
- editing/execCommand/dispatch-text-event-crash.html
- editing/style/apply-style-crash2.html


# stack trace of editing/execCommand/dispatch-text-event-crash.html
STDERR: [1:1:0123/001458.856025:FATAL:ng_inline_node.cc(461)] Check failed: IsPrepareLayoutFinished() && !GetLayoutBlockFlow()->NeedsCollectInlines(). 
STDERR: #0 0x00000311fe2c base::debug::StackTrace::StackTrace()
STDERR: #1 0x00000313ef03 logging::LogMessage::~LogMessage()
STDERR: #2 0x0000057e0829 blink::NGInlineNode::Data()
STDERR: #3 0x0000057e15f6 blink::NGInlineNode::ComputeOffsetMappingIfNeeded()
STDERR: #4 0x0000057dd5a8 blink::NGOffsetMapping::GetFor()
STDERR: #5 0x000005775416 blink::LayoutText::ContainsCaretOffset()
STDERR: #6 0x0000051032d8 blink::IsVisuallyEquivalentCandidate()
STDERR: #7 0x0000050a7483 blink::PreviousCandidateAlgorithm<>()
STDERR: #8 0x0000050a73de blink::PreviousCandidate()
STDERR: #9 0x0000050fbdfd blink::CanonicalPositionOf()
STDERR: #10 0x0000050f922f blink::VisiblePositionTemplate<>::Create()
STDERR: #11 0x0000050f9ab2 blink::CreateVisiblePosition()
STDERR: #12 0x0000050f9f8d blink::VisibleSelectionTemplate<>::CreateWithGranularity()
STDERR: #13 0x0000050fbba0 blink::CreateVisibleSelection()
STDERR: #14 0x0000050ed0c2 blink::SelectionEditor::UpdateCachedVisibleSelectionIfNeeded()
STDERR: #15 0x0000050ece25 blink::SelectionEditor::ComputeVisibleSelectionInDOMTree()
STDERR: #16 0x0000050cd905 blink::FrameCaret::IsActive()
STDERR: #17 0x0000050cdb4f blink::FrameCaret::ShouldBlinkCaret()
STDERR: #18 0x0000050cdab2 blink::FrameCaret::UpdateAppearance()
STDERR: #19 0x0000050cde36 blink::FrameCaret::UpdateStyleAndLayoutIfNeeded()
STDERR: #20 0x00000525a5fd blink::LocalFrameView::UpdateStyleAndLayoutIfNeededRecursiveInternal()
STDERR: #21 0x000005257fa8 blink::LocalFrameView::UpdateStyleAndLayoutIfNeededRecursive()
STDERR: #22 0x00000525676d blink::LocalFrameView::UpdateLifecyclePhasesInternal()
STDERR: #23 0x000005256587 blink::LocalFrameView::UpdateAllLifecyclePhases()
STDERR: #24 0x00000590a33e blink::PageAnimator::UpdateAllLifecyclePhases()
STDERR: #25 0x0000052d1e38 blink::WebViewImpl::UpdateLifecycle()

# stack trace of editing/style/apply-style-crash2.html
STDERR: [1:1:0123/001531.994859:FATAL:ng_inline_node.cc(461)] Check failed: IsPrepareLayoutFinished() && !GetLayoutBlockFlow()->NeedsCollectInlines(). 
STDERR: #0 0x00000311fe2c base::debug::StackTrace::StackTrace()
STDERR: #1 0x00000313ef03 logging::LogMessage::~LogMessage()
STDERR: #2 0x0000057e0829 blink::NGInlineNode::Data()
STDERR: #3 0x0000057e15f6 blink::NGInlineNode::ComputeOffsetMappingIfNeeded()
STDERR: #4 0x0000057dd5a8 blink::NGOffsetMapping::GetFor()
STDERR: #5 0x00000577534a blink::LayoutText::HasNonCollapsedText()
STDERR: #6 0x000005100541 blink::HasRenderedNonAnonymousDescendantsWithHeight()
STDERR: #7 0x000005103436 blink::IsVisuallyEquivalentCandidate()
STDERR: #8 0x0000050a6823 blink::NextCandidateAlgorithm<>()
STDERR: #9 0x0000050a677e blink::NextCandidate()
STDERR: #10 0x0000050fbdd9 blink::CanonicalPositionOf()
STDERR: #11 0x0000050f922f blink::VisiblePositionTemplate<>::Create()
STDERR: #12 0x0000050f9ab2 blink::CreateVisiblePosition()
STDERR: #13 0x0000050f9f8d blink::VisibleSelectionTemplate<>::CreateWithGranularity()
STDERR: #14 0x0000050fbba0 blink::CreateVisibleSelection()
STDERR: #15 0x0000050eeddd blink::SelectionModifier::PrepareToModifySelection()
STDERR: #16 0x0000050f17a5 blink::SelectionModifier::Modify()
STDERR: #17 0x0000050c9d2c blink::FrameSelection::Modify()
STDERR: #18 0x0000050a265c blink::DOMSelection::modify()
 

Comment 1 by yosin@chromium.org, Jan 25 2018

Blocking: 714962
Status: Fixed (was: Available)
The crash doesn't reproduce on ToT@r585567 with EditingNG enabled.

Sign in to add a comment