New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805776 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Turn-off Harmony experiment in M65 branch

Project Member Reported by tapted@chromium.org, Jan 25 2018

Issue description

Chrome Version       : 65

Creating a bug for turning off Harmony in M65 branch (Branch number: 3325) to prevent it going to Beta and continuing experiment in trunk.

m65 version of  Issue 789770  where this was done for m64.
 

Comment 1 by tapted@chromium.org, Jan 25 2018

I'm running some jobs on trunk in https://chromium-review.googlesource.com/c/chromium/src/+/885384 before rebasing to refs/branch-heads/3325

Comment 2 by tapted@chromium.org, Jan 25 2018

Cc: patricia...@chromium.org
Components: UI>Browser>Bubbles>PageInfo
Labels: ReleaseBlock-Stable
There's a test failure

[ RUN      ] PageInfoBubbleViewsMacTest.BubbleClosesOnKeyboardTabSwitch/1
../../chrome/browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm:99: Failure
Expected equality of these values:
  GetParam().bubble_type
    Which is: 2
  PageInfoBubbleView::GetShownBubbleType()
    Which is: 0

I don't think it affects the release build, but it would be nice to clear up so it doesn't go red in go/betabuilders. Should be simple (that test just tests the views bubble, so should be disabled/skipped or force-enable the flag).

Comment 3 by tapted@chromium.org, Jan 30 2018

Labels: Merge-Request-65
Requesting merge for CL in https://chromium-review.googlesource.com/c/chromium/src/+/885384 directly to refs/branch-heads/3325 (m65). I'll split out the test fix and land it on trunk.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 31 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb652b348c701cc2341ebee451102926a86a2f3

commit 7fb652b348c701cc2341ebee451102926a86a2f3
Author: Trent Apted <tapted@chromium.org>
Date: Wed Jan 31 03:06:08 2018

[m65 only] Disable Harmony for M65.

TBR=tapted@chromium.org

Bug:  805776 
Change-Id: Iec875c6071357d38b1826300bba6192aef173598
Reviewed-on: https://chromium-review.googlesource.com/895125
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#195}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/7fb652b348c701cc2341ebee451102926a86a2f3/chrome/browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm
[modify] https://crrev.com/7fb652b348c701cc2341ebee451102926a86a2f3/ui/base/ui_base_features.cc
[modify] https://crrev.com/7fb652b348c701cc2341ebee451102926a86a2f3/ui/views/controls/button/radio_button_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d9f7ea17a064af1a3b87a9173500ee4c41ff8f6

commit 6d9f7ea17a064af1a3b87a9173500ee4c41ff8f6
Author: Trent Apted <tapted@chromium.org>
Date: Thu Feb 01 00:23:16 2018

Fix some uninteresting test failures when Harmony is not default

With --disable-features=SecondaryUiMd, two tests fail for uninteresting
reasons:

 - PageInfoBubbleViewsMacTest.BubbleClosesOnKeyboardTabSwitch
 - RadioButtonTest.FocusOnClick

Update the tests.

Bug:  805776 
Change-Id: I305f2ea12ad0a3fb8114420995888654bc2151f3
Reviewed-on: https://chromium-review.googlesource.com/895062
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533487}
[modify] https://crrev.com/6d9f7ea17a064af1a3b87a9173500ee4c41ff8f6/chrome/browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm
[modify] https://crrev.com/6d9f7ea17a064af1a3b87a9173500ee4c41ff8f6/ui/views/controls/button/radio_button_unittest.cc

Sign in to add a comment