New issue
Advanced search Search tips

Issue 805771 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 694033



Sign in to add a comment

Try bot group optional_builders1 is full of linux_chromium_ozone_compile_only_ng jobs

Project Member Reported by wangxianzhu@chromium.org, Jan 25 2018

Issue description

linux_chromium_ozone_compile_only_ng seems to have too many try jobs which not only queue up by themselves but also block the slaves in the group from serving other try bots e.g. linux_layout_tests_slimming_paint_v2. For now on the 12 slaves, about 90% of the recent jobs are for linux_chromium_ozone_compile_only_ng.

Should we move linux_chromium_ozone_compile_only_ng out of optional_builders1 which looks like no longer an optional trybot and the current slaves can't meet the load demand of it?


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9544bf3c7cb0639977b7c56b6f9db1b272cef60b

commit 9544bf3c7cb0639977b7c56b6f9db1b272cef60b
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Jan 25 02:06:15 2018

Revert "Raise linux_chromium_ozone_compile_ng cq experiment from 10% to 50%"

This reverts commit 9dcd8a50be9b54ed785a24db76b3908da8be300f.

Reason for revert: This overloads the slaves in the group.

Bug:  805771 

Original change's description:
> Raise linux_chromium_ozone_compile_ng cq experiment from 10% to 50%
>
> Bot is stable over the past months.
> BUG= 694033 
>
> Change-Id: I2f383da545eb39c4745a7cb18e35473f7aa62300
> Reviewed-on: https://chromium-review.googlesource.com/793472
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#531503}

TBR=dpranke@chromium.org,tonikitoo@igalia.com

Change-Id: Ifdca60a3a76c71c1433dca88a5bb278b9165c85a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  694033 
Reviewed-on: https://chromium-review.googlesource.com/884556
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531783}
[modify] https://crrev.com/9544bf3c7cb0639977b7c56b6f9db1b272cef60b/infra/config/cq.cfg

Cc: toniki...@igalia.com dpranke@chromium.org
There is a big queue (>70 jobs) of the try bot. Can/should we clean it up?
I'd just let it drain and get caught up. We need to move the builder into the CQ pool; I thought we had already, but I guess not (and my mistake for not checking).
Cc: -toniki...@igalia.com toniki...@chromium.org
Although I believe bot should be able to catch up over night, I can't really comment. I defer handling of this to you guys.

PS: I would appreciate a notice here, so we could try to reland the original CL.

Comment 6 by foolip@chromium.org, Jan 25 2018

Status: Available (was: Unconfirmed)
Doing a bit of Blink>Infra triage here. Sounds like the problem is confirmed to be real, but a P1 with no owner might go nowhere. wangxianzhu@, dpranke@, are either of you the right owner?
Status: Fixed (was: Available)
As we have changed the load back to 10% and the queue seems OK now, I'm closing this bug. Moving the builder to CQ pool and increasing its load can be another task.

Comment 8 by kojii@chromium.org, Jan 31 2018

Was this enabled again? The 12 bots for linux_layout_tests_layout_ng and linux_layout_tests_slimming_paint_v2 are running out of capacity again.
Cc: tandrii@chromium.org
Status: Available (was: Fixed)
It seems that 12 bots are not enough for 10% linux_chromium_ozone_compile_only_ng and 5% linux_chromium_dbg_ng CQ tryjobs.

There should be a relief when we move linux_chromium_ozone_compile_only_ng into the CQ pool. tonikitoo@, qyearsley@ and dpranke@ will that happen soon?

Also 5% linux_chromium_dbg_ng CQ seems for some experiment and that the should remove the 5% CQ when the experiment ends (https://cs.chromium.org/chromium/src/infra/config/cq.cfg?rcl=880ae61e68a8806986cd8678641c8d6e0a0c1d3c&l=104). tandrii@ can we remove now?
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
Assigning to myself to track the progress.
Owner: dpranke@chromium.org
I'll take this, actually, and post a CL later this afternoon.
Blocking: 694033
Status: Started (was: Assigned)
CL: https://crrev.com/c/897405
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f94d295696830bbacf14cb4287ff34fd9eb7d353

commit f94d295696830bbacf14cb4287ff34fd9eb7d353
Author: Dirk Pranke <dpranke@chromium.org>
Date: Fri Feb 02 00:28:18 2018

Move linux_chromium_ozone_compile_only_ng into the CQ pool.

This moves the builder from one of the optional pools on
tryserver.chromium.linux to the main cq pool, since we
want to add this to the CQ.

R=martiniss@chromium.org
BUG= 805771 

Change-Id: I2d9853fbae7128bad6d8edfb3020d096d390b0e9
Reviewed-on: https://chromium-review.googlesource.com/897405
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/f94d295696830bbacf14cb4287ff34fd9eb7d353/masters/master.tryserver.chromium.linux/slaves.cfg

Status: Fixed (was: Started)

Sign in to add a comment