FEATURE_WITH_PARAMS_VALUE_TYPE flags don't work on ChromeOS devices |
||||
Issue descriptionabout_flags.cc flags defined with FEATURE_WITH_PARAMS_VALUE_TYPE don't seem to work on ChromeOS devices: the relevant parameter doesn't get set. This only applies to ChromeOS devices; it does *not* reproduce when running a ChromeOS build on Linux as described in https://chromium.googlesource.com/chromium/src/+/master/docs/chromeos_build_instructions.md. It's a little hard to tell what's going on, but here is how I concluded that FEATURE_WITH_PARAMS_VALUE_TYPE is broken: - The #enable-mark-http-as flag doesn't work on a ChromeOS device, but it does work with ChromeOS on Linux and on every other platform. This is very odd because there's absolutely nothing platform-specific about the feature. - I then followed the instructions at [1] to deploy a local Chrome build to a ChromeOS device. I inserted log statements for several flags defined with FEATURE_WITH_PARAMS_VALUE_TYPE to confirm that the relevant parameter wasn't getting set for any of them when I set the flag in chrome://flags and rebooted. [1] https://docs.google.com/document/d/173nob44RjfE0DAbX8pIkVtMA-uozAG29Wq5m0WROKX4/edit (googler-only)
,
Jan 25 2018
,
Jan 25 2018
We (the metrics team) are tentatively planning to pick this up for Q1, but don't yet have concrete owner nor more precise timing estimate.
,
Sep 14
,
Sep 14
Is there any way of circumventing this bug? In our case, it's blocking a11y and test reviews for a feature we want to launch in m70 on Chrome OS. For example, is it possible to pass those params via command line flags or force an experiment group of an existing field trial?
,
Sep 14
Not that I know of. It just needs to be investigated and fixed - I suspect the fix is not very complicated, but requires debugging what's wrong first. We unfortunately haven't had the cycles to look at this. If this is important to your feature, perhaps you can investigate? Happy to answer questions about it.
,
Oct 29
Issue 899703 has been merged into this issue.
,
Oct 29
Issue 887846 has been merged into this issue.
,
Dec 13
This came up again during testing for another feature in Issue 914313. I'm not sure where to begin debugging this issue to try to work on a fix. For now, we've manually verified the feature ourselves on ChromeOS.
,
Dec 17
|
||||
►
Sign in to add a comment |
||||
Comment 1 by est...@chromium.org
, Jan 25 2018