networkType in RTCIceCandidateStats doesn't identify VPN interfaces |
||||
Issue descriptionThere's now a networkType field in RTCIceCandidateStats, to communicate what type of network interface the local socket is using, but it's always "unknown" for VPN interfaces. The native WebRTC code has some logic to detect VPN interfaces by name. Chromium should at minimum use this, if there are no other indicators it can use.
,
Mar 1 2018
Is this finished?
,
Mar 1 2018
No; still need to land this CL: https://chromium-review.googlesource.com/c/chromium/src/+/892084
,
Mar 1 2018
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b36a6c8d2cd530f9d5dd42559a9ab5359ce83bac commit b36a6c8d2cd530f9d5dd42559a9ab5359ce83bac Author: Taylor Brandstetter <deadbeef@chromium.org> Date: Fri Mar 02 19:38:34 2018 Determine network adapter type for WebRTC using string matching rules. If the connection type received from the browser process is NetworkChangeNotifier::CONNECTION_UNKNOWN, then use WebRTC's string matching rules to attempt to determine the type given the interface name. This is what WebRTC's default network manager (used by native apps) does. Bug: 805759 Change-Id: I19950ee918146f3cce4fbc0bc40eef996ed7065a Reviewed-on: https://chromium-review.googlesource.com/892084 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#540587} [modify] https://crrev.com/b36a6c8d2cd530f9d5dd42559a9ab5359ce83bac/content/renderer/p2p/ipc_network_manager.cc [modify] https://crrev.com/b36a6c8d2cd530f9d5dd42559a9ab5359ce83bac/content/renderer/p2p/ipc_network_manager_unittest.cc
,
Mar 2 2018
Considering this "done" enough for now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jan 25 2018