New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

networkType in RTCIceCandidateStats doesn't identify VPN interfaces

Project Member Reported by deadbeef@chromium.org, Jan 25 2018

Issue description

There's now a networkType field in RTCIceCandidateStats, to communicate what type of network interface the local socket is using, but it's always "unknown" for VPN interfaces.

The native WebRTC code has some logic to detect VPN interfaces by name. Chromium should at minimum use this, if there are no other indicators it can use.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8bac1d994e78187f1cc53137c1b17111961c4059

commit 8bac1d994e78187f1cc53137c1b17111961c4059
Author: Taylor Brandstetter <deadbeef@webrtc.org>
Date: Thu Jan 25 19:09:34 2018

Add more string matching rules for detecting VPN interfaces.

"tun", "utun" and "tap" interfaces will now be assumed to be VPNs, if
the type is otherwise unknown.

This CL also moves GetAdapterTypeFromName out of BasicNetworkManager,
so that other network manager classes (e.g., the one in Chromium) can
use it too.

Bug:  chromium:805759 
Change-Id: I9988619666e2a9449cf5c089d24cf7d3afde8239
Reviewed-on: https://webrtc-review.googlesource.com/43580
Reviewed-by: Zhi Huang <zhihuang@webrtc.org>
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21767}
[modify] https://crrev.com/8bac1d994e78187f1cc53137c1b17111961c4059/rtc_base/network.cc
[modify] https://crrev.com/8bac1d994e78187f1cc53137c1b17111961c4059/rtc_base/network.h

Is this finished?
Status: Fixed (was: Started)
No; still need to land this CL: https://chromium-review.googlesource.com/c/chromium/src/+/892084
Status: Started (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36a6c8d2cd530f9d5dd42559a9ab5359ce83bac

commit b36a6c8d2cd530f9d5dd42559a9ab5359ce83bac
Author: Taylor Brandstetter <deadbeef@chromium.org>
Date: Fri Mar 02 19:38:34 2018

Determine network adapter type for WebRTC using string matching rules.

If the connection type received from the browser process is

NetworkChangeNotifier::CONNECTION_UNKNOWN, then use WebRTC's string
matching rules to attempt to determine the type given the interface
name. This is what WebRTC's default network manager (used by native
apps) does.

Bug:  805759 
Change-Id: I19950ee918146f3cce4fbc0bc40eef996ed7065a
Reviewed-on: https://chromium-review.googlesource.com/892084
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540587}
[modify] https://crrev.com/b36a6c8d2cd530f9d5dd42559a9ab5359ce83bac/content/renderer/p2p/ipc_network_manager.cc
[modify] https://crrev.com/b36a6c8d2cd530f9d5dd42559a9ab5359ce83bac/content/renderer/p2p/ipc_network_manager_unittest.cc

Status: Fixed (was: Started)
Considering this "done" enough for now.

Sign in to add a comment