DevTools: performance problems with OOPIFs |
|||||||||
Issue descriptionWith OOPIFs we have a lot of RenderFrameDevToolsAgentHost instances, and have at least the following performance problems: - linear lookup in FindAgentHost() method; - attaching to all service workers from each OOPIF's agent host; - notifying about each frame navigation from main frame _and_ every OOPIF.
,
Jan 25 2018
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e72dcf29d2274244876e5b0d4e32a1e36c06d88c commit e72dcf29d2274244876e5b0d4e32a1e36c06d88c Author: Dmitry Gozman <dgozman@chromium.org> Date: Sat Jan 27 15:28:16 2018 [DevTools] Fix performance problems with OOPIFs - linear lookup changed to map; - NotifyNavigated just once per frame; - do not attach to service worker from each OOPIF. Bug: 805757 Change-Id: I1c912cf52fb74afc5eeb8a9fe8ae35f422eda8c9 Reviewed-on: https://chromium-review.googlesource.com/885244 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532223} [modify] https://crrev.com/e72dcf29d2274244876e5b0d4e32a1e36c06d88c/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/e72dcf29d2274244876e5b0d4e32a1e36c06d88c/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/e72dcf29d2274244876e5b0d4e32a1e36c06d88c/content/browser/devtools/protocol/target_auto_attacher.cc [modify] https://crrev.com/e72dcf29d2274244876e5b0d4e32a1e36c06d88c/content/browser/devtools/protocol/target_auto_attacher.h [modify] https://crrev.com/e72dcf29d2274244876e5b0d4e32a1e36c06d88c/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/e72dcf29d2274244876e5b0d4e32a1e36c06d88c/content/browser/devtools/render_frame_devtools_agent_host.h
,
Jan 29 2018
,
Jan 29 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 30 2018
,
Jan 31 2018
dgozman@ Request you to please provide steps to verify this CL on the latest Chrome builds if manual verification is required for this issue. Thanks..
,
Jan 31 2018
There is no way to manually verify this. Things should just be faster with a lot of OOPIFs.
,
Jan 31 2018
,
Jan 31 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b10589c11c5832e99df620d1a3e113cc84bf49bb commit b10589c11c5832e99df620d1a3e113cc84bf49bb Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Jan 31 21:40:54 2018 [DevTools] Fix performance problems with OOPIFs - linear lookup changed to map; - NotifyNavigated just once per frame; - do not attach to service worker from each OOPIF. (cherry picked from commit e72dcf29d2274244876e5b0d4e32a1e36c06d88c) Bug: 805757 Change-Id: I1c912cf52fb74afc5eeb8a9fe8ae35f422eda8c9 Reviewed-on: https://chromium-review.googlesource.com/885244 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532223} Reviewed-on: https://chromium-review.googlesource.com/896106 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#215} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/b10589c11c5832e99df620d1a3e113cc84bf49bb/content/browser/devtools/protocol/target_auto_attacher.cc [modify] https://crrev.com/b10589c11c5832e99df620d1a3e113cc84bf49bb/content/browser/devtools/protocol/target_auto_attacher.h [modify] https://crrev.com/b10589c11c5832e99df620d1a3e113cc84bf49bb/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/b10589c11c5832e99df620d1a3e113cc84bf49bb/content/browser/devtools/render_frame_devtools_agent_host.h |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by gov...@chromium.org
, Jan 25 2018