New issue
Advanced search Search tips

Issue 805756 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"external/wpt/html/semantics/tabular-data/processing-model-1/span-limits.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 25 2018

Issue description

"external/wpt/html/semantics/tabular-data/processing-model-1/span-limits.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxleHRlcm5hbC93cHQvaHRtbC9zZW1hbnRpY3MvdGFidWxhci1kYXRhL3Byb2Nlc3NpbmctbW9kZWwtMS9zcGFuLWxpbWl0cy5odG1sDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by ortuno@chromium.org, Jan 25 2018

Cc: qyears...@chromium.org
qyearsley: I see you removed the timeout expectation for this test in  issue 755810 . The test keeps timing out on Win7, should we add the test expectation back?
Labels: -Sheriff-Chromium
Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
Yep, I think we should add the expectation back.
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Feb 2 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "external/wpt/html/semantics/tabular-data/processing-model-1/span-limits.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxleHRlcm5hbC93cHQvaHRtbC9zZW1hbnRpY3MvdGFidWxhci1kYXRhL3Byb2Nlc3NpbmctbW9kZWwtMS9zcGFuLWxpbWl0cy5odG1sDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 5 by yutak@chromium.org, Feb 2 2018

Owner: yutak@chromium.org
Status: Started (was: Assigned)
Hi qyearsley,

The degree of flakiness of this test is rather high, so this should be
handled quickly.

I'm going to take this over and update the test expectations. Thanks!

Comment 6 by yutak@chromium.org, Feb 2 2018

As I don't see any failures on Mac10.11, I'm going to just mark the test as
timeout only on Win7.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e766e99fbb9c0734eebeb06975b9ea51783a3a

commit c6e766e99fbb9c0734eebeb06975b9ea51783a3a
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Feb 02 07:02:14 2018

Update layout test expectations for two tests.

TBR=qyearsley@chromium.org,treib@chromium.org,sfiera@chromium.org

Bug: 805756,  808153 
Change-Id: Id7e8b218cf37d51c7ef0d6cd34b2abe6bd9d1be2
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/897236
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533982}
[modify] https://crrev.com/c6e766e99fbb9c0734eebeb06975b9ea51783a3a/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/c6e766e99fbb9c0734eebeb06975b9ea51783a3a/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by yutak@chromium.org, Feb 2 2018

Cc: yutak@chromium.org
Components: Blink>Infra>Ecosystem
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Started)
The test is marked as timing out.

Who can own this, though? Maybe WPT folks? This test seems just way too slow.
In general, the Ecosystem Infra team can't practically look at all of the failing tests that are imported from WPT.

In theory, there are directory owners in both Chromium and upstream wpt. In this case, for wpt/html/semantics/ it's dom-dev@chromium.org and https://github.com/ayg respectively.

In June last year, tkent@ marked this test as slow:
https://github.com/w3c/web-platform-tests/commit/24d6e5e2e4990677101cc52c673730ec07590733

For this particular test, it seems to be testing that colspan has a max value of 1000, and rowspan has a max value of 65534. Perhaps breaking this test into colspan-limits.html and rowspan-limits.html would break it into two tests that might not time out if they get in under the limit?
Components: Blink>HTML
Inviting DOM team for this.
Cc: tkent@chromium.org
Labels: -Sheriff-Chromium
Project Member

Comment 13 by chromium...@appspot.gserviceaccount.com, May 30 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "external/wpt/html/semantics/tabular-data/processing-model-1/span-limits.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxleHRlcm5hbC93cHQvaHRtbC9zZW1hbnRpY3MvdGFidWxhci1kYXRhL3Byb2Nlc3NpbmctbW9kZWwtMS9zcGFuLWxpbWl0cy5odG1sDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
This is flaking so rarely that I am taking this off the sheriff queue again.

Sign in to add a comment