New issue
Advanced search Search tips

Issue 805748 link

Starred by 2 users
Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

libsmbclient: smbc_ftruncate always gives 22 EINVAL error

Project Member Reported by allenvic@google.com, Jan 25 2018 
Samba version: 4.5.3

Calling smbc_ftruncate() in >=SMB2 always returns an error and sets the errno to 22 (EINVAL).

This was previously reported on the samba channel here: https://bugzilla.samba.org/show_bug.cgi?id=12479

The resulting fix is located here:
https://github.com/samba-team/samba/commit/e0f1ed9f450851bf5b7fec84577b50047309db3f

The change was included in the Samba release 4.5.4.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/06bc4e157e9c3d5886b84c4298a47bd4f3383b5f

commit 06bc4e157e9c3d5886b84c4298a47bd4f3383b5f
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Jan 25 10:43:19 2018

net-fs/samba: Fix ftruncate to support SMB2

cli_ftruncate was failing for SMB2+ connections. This change fixes
ftruncate so that SMB2+ connections will be able to properly call it.

This bug was previously reported in a Samba channel and a fix has
already been uploaded. The bug was reported on Samba 4.4.8 and the fix
was made live on Samba 4.5.4

Previous bug report: https://bugzilla.samba.org/show_bug.cgi?id=12479
Patch:
https://github.com/samba-team/samba/commit/e0f1ed9f450851bf5b7fec84577b50047309db3f

BUG=chromium:805748
TEST=emerges and ftruncate no longer returns error

Change-Id: I6a1a98010e8fceeabb65170947bf74428c96e6a9
Reviewed-on: https://chromium-review.googlesource.com/884994
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/06bc4e157e9c3d5886b84c4298a47bd4f3383b5f/net-fs/samba/files/samba-4.5.3-fix-ftruncate-smb2.patch
[modify] https://crrev.com/06bc4e157e9c3d5886b84c4298a47bd4f3383b5f/net-fs/samba/samba-4.5.3.ebuild
[rename] https://crrev.com/06bc4e157e9c3d5886b84c4298a47bd4f3383b5f/net-fs/samba/samba-4.5.3-r11.ebuild

Comment 2 by matthewjoseph@chromium.org, Jan 26 2018

Components: OS>Systems>Network
Labels: mp-triage

Comment 3 by marcuskoehler@chromium.org, Jan 15

Labels: Enterprise-Triaged
►

Sign in to add a comment