New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805740 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit 28 days ago
Closed: Dec 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: surface workpace 2.0 errors

Project Member Reported by lushnikov@chromium.org, Jan 25 2018

Issue description

Currently, Workspaces 2.0 don't surface reasons why it doesn't map certain files to each other.

This causes a ton on confusion; we should be more transparent on how automapping works.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4859b2d9fa524b29e1aa61b5303fc37b33132c07

commit 4859b2d9fa524b29e1aa61b5303fc37b33132c07
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Thu Jan 25 08:56:48 2018

DevTools: split persistence bindings from automapping bindings

This patch introduces AutomappingBinding, that has additional
information related to the automapping process.

For now, the automappingBinding has only "exact" boolean flag.
In future, AutomappingBinding will be created for both successful
and failed bindings, surfacing binding errors.

R=dgozman
Bug= 805740 

Change-Id: I6245a8b26ae278635add9ef7a46e60886d59bd29
Reviewed-on: https://chromium-review.googlesource.com/884989
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531853}
[modify] https://crrev.com/4859b2d9fa524b29e1aa61b5303fc37b33132c07/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-expected.txt
[modify] https://crrev.com/4859b2d9fa524b29e1aa61b5303fc37b33132c07/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-nodejs-expected.txt
[modify] https://crrev.com/4859b2d9fa524b29e1aa61b5303fc37b33132c07/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-opens-filesystem-uisourcecode-expected.txt
[delete] https://crrev.com/d8100dc0019e9e0856da0b5711e76135b0f022cc/third_party/WebKit/LayoutTests/platform/win/http/tests/devtools/persistence/persistence-tabbed-editor-keeps-selected-tab-expected.txt
[modify] https://crrev.com/4859b2d9fa524b29e1aa61b5303fc37b33132c07/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/PersistenceTestRunner.js
[modify] https://crrev.com/4859b2d9fa524b29e1aa61b5303fc37b33132c07/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/4859b2d9fa524b29e1aa61b5303fc37b33132c07/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[modify] https://crrev.com/4859b2d9fa524b29e1aa61b5303fc37b33132c07/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39e7f07496b73307a619f16a3997fb7935872f19

commit 39e7f07496b73307a619f16a3997fb7935872f19
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Wed Jan 31 02:41:29 2018

DevTools: move TestMapping to use Persistence.addBdinging/removeBinding

This patch:
- migrates TestMapping to use generic Persistence methods
  addBinding/removeBinding instead of creating a custom mapping algorithm.
- removes enabling/disabling of automapping; instead, the automapping
  gets disposed.

Since the removal of DefaultMapping, Persistence doesn't need to support
different mapping algorithm implementations.

BUG= 805740 
R=dgozman

Change-Id: I5be46e4a3991011ae2bc7496619e4a1c9dcfb700
Reviewed-on: https://chromium-review.googlesource.com/892481
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533172}
[modify] https://crrev.com/39e7f07496b73307a619f16a3997fb7935872f19/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/PersistenceTestRunner.js
[modify] https://crrev.com/39e7f07496b73307a619f16a3997fb7935872f19/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/39e7f07496b73307a619f16a3997fb7935872f19/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a78f25a0b67f5ce93e331c69e7c0f9700636a8cb

commit a78f25a0b67f5ce93e331c69e7c0f9700636a8cb
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Tue Feb 13 07:48:53 2018

DevTools: prepare Automapping for statuses

This patch renames AutomappingBinding into AutomappingStatus.

The rename is to stress the conceptual difference between
PersistenceBinding and AutomappingStatus:
- PersistenceBinding will not exist unless there's a successful binding
  between UISourceCodes. Persistence will sync bound UISourceCodes.
- AutomappingStatus reports on the Automapping for the network
  UISourceCode. It exists regardless of the mapping success and will carry
  debugging information.

R=dgozman
BUG= 805740 

Change-Id: I345ba245099244b5c215aca022edd86416f400e2
Reviewed-on: https://chromium-review.googlesource.com/898165
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536282}
[modify] https://crrev.com/a78f25a0b67f5ce93e331c69e7c0f9700636a8cb/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/AutomappingTestRunner.js
[modify] https://crrev.com/a78f25a0b67f5ce93e331c69e7c0f9700636a8cb/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/PersistenceTestRunner.js
[modify] https://crrev.com/a78f25a0b67f5ce93e331c69e7c0f9700636a8cb/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/a78f25a0b67f5ce93e331c69e7c0f9700636a8cb/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Status: WontFix (was: Assigned)
DevTools bug triage: closing low-pri issues with low demand.

Sign in to add a comment